348496 - [mac] alltabs button not responding to hover

Status: RESOLVED DUPLICATE of bug 348293

(Firefox :: Tabbed Browser, defect)

Description

[(not reading, please use [e-mail] instead)]

[mac] alltabs button not responding to hover

from bug #347783:

> 2) There's a hover state defined on the alltabs-box but it no longer works
> because of the reorganization of the box and button into a stack. I'm guessing
> that the button is now absorbing the mouseover event and so the box never gets
> it. Not sure if there's a way to resolve that?

I'm going to spin this off to another bug, so I can work on it separately.

I think to fix this I am going to need create a new binding for the
alltabs-button stack (of box,box,toolbarbutton), where the toolbarbutton has
handlers for mouseover and mouseout.  then, on mouseover and mouseout of the
toolbarbutton, I'd set fakehover to "true" on the first box (which has opacity
of .65, except when in the "fakehover state", when it would be 1.0) and remove
the fakehover attribute on mouseout.

the reason this has to be a binding is so I can use it from
pinstripe/global/globalBindings.xml.  themes are scriptable, so to get
mouseover / mouseout to work, it needs to be a new binding in tabbrowser.xml

I'll discuss with mano, to see if this is a good idea or not.

Comment 1

[(not reading, please use [e-mail] instead)]

I think we want this for ff2

Comment 2

[(not reading, please use [e-mail] instead)]

asaf points out that we may not want hover, on pinstripe, see bug #347399

but I might need to do this new binding for winstripe, depending on what changes happen with the theme refresh for winstripe.

Comment 3

[(not reading, please use [e-mail] instead)]

actually, I think I can accomplish this without adding a new binding.

so we have a stack with {box1, box2, toolbarbutton}, and to animate, the background image is now on box1 with opacity .65 and we animate box2 with the blue  version by changing the opacity from 0.0 to 1.0.

but, to get the hover to work, I can just add a :hover rule to the toolbarbutton to use the background image (same as in box1) with opacity 1.0

I've tried this, and it does what we want.

note, I'll need this for the new scrollbutton down stack (box1, box2, toolbarbutton) which i need for bug #348496 (in order to animate it.)

if we decide not to change state on hover (see bug #347399), we can just remove the :hover rules from pinstripe/global/browser.css that I plan to add.

Comment 4

[(not reading, please use [e-mail] instead)]

a patch that makes the button respond to hover is in bug #347783.

it just some simple css that we can easily remove if we no longer want to change opacity on hover.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Feel free to resolve as a duplicate if/when bug 347783 gets fixed, but we do want to make sure this is fixed so blocking to track.

Comment 6

[(not reading, please use [e-mail] instead)]

Dear Mr. Short Term Memory,

sheesh, how sad is it that we logged this duplicate less than two hours after logging bug #348293?

Yours,

-Mr. Short Term Memory


*** This bug has been marked as a duplicate of 348293 ***