error when press cancel in dialog "Editing a repeating item" for recurrence event

VERIFIED FIXED

Status

Calendar
Calendar Views
--
trivial
VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: Damian Szczepanik, Assigned: ssitter)

Tracking

Trunk
x86
Windows XP

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060812 Calendar/0.3a2+

When you try to edit event with recurrence you have to confirm if you want to edit single event or all of them. If you press cancel to abort operation you get error.

Reproducible: Always

Steps to Reproduce:
1. create event with recurrence
2. open created event to edit it
   -> get dialog "Editing a repeating item" to confirm mode of editing: single, all or cancel
3. press cancel to abort operation
   -> error appears in error console
Actual Results:  
error console:

Error: itemToEdit has no properties
Source File: chrome://calendar/content/calendar-views.js
Line: 97


except this error works fine
(Reporter)

Updated

12 years ago
Version: unspecified → Trunk
(Assignee)

Updated

12 years ago
Assignee: nobody → ssitter
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 1

12 years ago
Created attachment 233467 [details] [diff] [review]
check return of getOccurrenceOrParent

Check return of getOccurrenceOrParent(). 
Add comment to getOccurrenceOrParent() that it can return null.
Attachment #233467 - Flags: second-review?(jminta)
Attachment #233467 - Flags: first-review?(mattwillis)
Comment on attachment 233467 [details] [diff] [review]
check return of getOccurrenceOrParent

> Index: mozilla/calendar/base/content/calendar-item-editing.js
> ===================================================================
> +// Returns null if the promt was cancelled.

Typo: correct spelling is "prompt".

r1=lilmatt with that fixed
Attachment #233467 - Flags: first-review?(mattwillis) → first-review+
(Assignee)

Comment 3

12 years ago
Created attachment 233503 [details] [diff] [review]
check return of getOccurrenceOrParent, v2

Fix typo. Carry over r1=lilmatt.
Attachment #233467 - Attachment is obsolete: true
Attachment #233503 - Flags: second-review?(jminta)
Attachment #233503 - Flags: first-review+
Attachment #233467 - Flags: second-review?(jminta)

Comment 4

12 years ago
Comment on attachment 233503 [details] [diff] [review]
check return of getOccurrenceOrParent, v2

r2=jminta
Attachment #233503 - Flags: second-review?(jminta) → second-review+

Comment 5

12 years ago
patch checked in.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

12 years ago
verified
Status: RESOLVED → VERIFIED
(Reporter)

Updated

12 years ago
Whiteboard: [litmus testcase wanted]
(Reporter)

Comment 7

12 years ago
Litmus testcase 2644 created
Whiteboard: [litmus testcase wanted]
You need to log in before you can comment on or make changes to this bug.