348500 - error when press cancel in dialog "Editing a repeating item" for recurrence event

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Damian Szczepanik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060812 Calendar/0.3a2+

When you try to edit event with recurrence you have to confirm if you want to edit single event or all of them. If you press cancel to abort operation you get error.

Reproducible: Always

Steps to Reproduce:
1. create event with recurrence
2. open created event to edit it
   -> get dialog "Editing a repeating item" to confirm mode of editing: single, all or cancel
3. press cancel to abort operation
   -> error appears in error console
Actual Results:  
error console:

Error: itemToEdit has no properties
Source File: chrome://calendar/content/calendar-views.js
Line: 97


except this error works fine

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: check return of getOccurrenceOrParent

Check return of getOccurrenceOrParent(). 
Add comment to getOccurrenceOrParent() that it can return null.

Comment 2

[Matthew (lilmatt) Willis]

Comment on attachment 233467 [details] [diff] [review]
check return of getOccurrenceOrParent

> Index: mozilla/calendar/base/content/calendar-item-editing.js
> ===================================================================
> +// Returns null if the promt was cancelled.

Typo: correct spelling is "prompt".

r1=lilmatt with that fixed

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: check return of getOccurrenceOrParent, v2

Fix typo. Carry over r1=lilmatt.

Comment 4

[Joey Minta]

Comment on attachment 233503 [details] [diff] [review]
check return of getOccurrenceOrParent, v2

r2=jminta

Comment 5

[Joey Minta]

patch checked in.

Comment 6

[Damian Szczepanik]

verified

Comment 7

[Damian Szczepanik]

Litmus testcase 2644 created