Closed
Bug 348559
Opened 18 years ago
Closed 18 years ago
Introduce CheckLoadURIStrWithPrincipal
Categories
(Core :: Security: CAPS, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
6.88 KB,
patch
|
dveditz
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
CheckLoadURIStr's using a string to identify the entity doing the load is just broken...
Assignee | ||
Comment 1•18 years ago
|
||
Attachment #233523 -
Flags: superreview?(jst)
Attachment #233523 -
Flags: review?(dveditz)
Comment 2•18 years ago
|
||
Comment on attachment 233523 [details] [diff] [review]
Fix
r=dveditz
Attachment #233523 -
Flags: review?(dveditz) → review+
Comment 3•18 years ago
|
||
Comment on attachment 233523 [details] [diff] [review]
Fix
- In caps/idl/nsIScriptSecurityManager.idl:
+ * Similar to checkLoadURIWithPrincipal but there are two differences:
+ *
+ * 1) The URI is a string, not a URI object.
+ * 2) This function assumes that the URI may still be subject to fixup (and
...
Nit of the day: Remove one of the spaces following "1)".
sr=jst
Attachment #233523 -
Flags: superreview?(jst) → superreview+
Assignee | ||
Comment 4•18 years ago
|
||
Fixed, with that nit addressed.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•18 years ago
|
||
*** Bug 347394 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•