348577 - Implement MathML <mtable> with display:inline-table (mtable has incorrect baseline)

Status: RESOLVED FIXED

(Core :: MathML, defect, P3)

Description

[rbs]

Currently <mtable> is implemented with wrappers that force it to behave as an inline-table. Its implementation should be revisited when display:inline-table is supported (bug 18217). This might also led to removing the code added for bug 344281.

Comment 1

[Karl Tomlinson (:karlt)]

nsIFrame::GetBaseline() now positions non-inline blocks above the baseline, so the ascent of the mtable is being ignored and they appear twice as high as they should be.

Using display: inline-table fixes this.

Comment 2

[Mike Schroepfer]

Karl - should this block?

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: screenshot of matrices

If this bug is not fixed, then contents of matrices will be misaligned, as seen on the right, which should look like the matrix on the left.
So I think this should block.

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: conditionals are also affected

There shouldn't be empty space to the right of the bottom half of the brace.

Comment 5

[Karl Tomlinson (:karlt)]

... and this is not hard to fix.

Comment 6

[Karl Tomlinson (:karlt)]

The symptoms above are a regression from bug 367332 because it is since those changes that non-inline frames don't really have a baseline (which is reasonable), but without changes in bug 367332 we wouldn't have had inline-table  to fix this.  Now we need to use inline-table to get the desired baseline.

Comment 7

[Bill Gianopoulos [:WG9s]]

Attachment: WIP patch

This is a work-in-progress.  Still some things to iron out.

Comment 8

[Bill Gianopoulos [:WG9s]]

Comment on attachment 295545 [details] [diff] [review]
WIP patch

Oops.  uploaded the wrong file

Comment 9

[Bill Gianopoulos [:WG9s]]

Attachment: WIP patch

Comment 10

[Bill Gianopoulos [:WG9s]]

Attachment: patch v1

Comment 11

[Bill Gianopoulos [:WG9s]]

Attachment: patch v2

This patch includes the code to backout bug 344281 and bug 355993.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 295628 [details] [diff] [review]
patch v2

>Index: layout/base/nsCSSFrameConstructor.h
>-   * positioned or floated, in which case its placeholder will be in
..
>+   * positioned, in which case its placeholder will be in aChildItems).

Please don't lose the "or floated" part.

The rest of this looks great!  sr=bzbarsky

Comment 13

[Bill Gianopoulos [:WG9s]]

Attachment: patch for check-in

Addresses review comments.

Comment 14

[Karl Tomlinson (:karlt)]

Checked in, thanks very much!

1.1447      mozilla/layout/base/nsCSSFrameConstructor.cpp
1.250       mozilla/layout/base/nsCSSFrameConstructor.h
1.22        mozilla/layout/mathml/base/src/nsMathMLmrowFrame.cpp
1.15        mozilla/layout/mathml/base/src/nsMathMLmrowFrame.h
1.72        mozilla/layout/mathml/base/src/nsMathMLmtableFrame.cpp
1.37        mozilla/layout/mathml/content/src/mathml.css