Closed Bug 348625 Opened 18 years ago Closed 18 years ago

use whitelist to suppress remote lookups

Categories

(Toolkit :: Safe Browsing, defect)

Product:
Toolkit
Component:
Safe Browsing
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2

People

(Reporter: tony, Assigned: tony)

References

Details

(Keywords: fixed1.8.1)

Attachments

(2 files)

v1: use whitelist to suppress remote lookups
13.49 KB, patch
provos
: review+
bryner
: superreview+
mtschrep
: approval1.8.1+
Details | Diff | Splinter Review
v1: add first path to domain for checking
2.41 KB, patch
provos
: review+
bryner
: superreview+
mtschrep
: approval1.8.1+
Details | Diff | Splinter Review 
In Google Toolbar, if the user decides to check with Google on every page load, we do an optimization where we first check the url and domain white lists.  If the site is on the white list, we don't bother doing a remote check.  This is better for privacy reasons and it saves a large amount of bandwidth.

We should do the same in Firefox 2, except it's a bit trickier because the white list provider and the remote check provider may be different (or maybe the remote check provider doesn't support lists, etc).  So instead, we'll check to see if the update list url is the same domain as the remote check url.  If they are the same, then we can use the optimization mentioned above.  If they're different, we go ahead and send the url for remote lookup.
Suppress remote lookups if the local list provider is the same as the remote lookup provider and the URL is in the whitelist.
Attachment #233646 - Flags: review?(provos)
Comment on attachment 233646 [details] [diff] [review]
v1: use whitelist to suppress remote lookups

looks good.  would be nice to have a unittest for this.
Attachment #233646 - Flags: review?(provos) → review+
Attachment #233646 - Flags: superreview?(bryner)
Flags: blocking-firefox2?
Flags: blocking-firefox2? → blocking-firefox2+
Target Milestone: --- → Firefox 2
Attachment #233646 - Flags: superreview?(bryner) → superreview+
on trunk
Summary: use whitelist to surpress remote lookups → use whitelist to suppress remote lookups
Blocks: 349227
Attachment #233646 - Flags: approval1.8.1?
Comment on attachment 233646 [details] [diff] [review]
v1: use whitelist to suppress remote lookups

a=schrep for drivers.
Attachment #233646 - Flags: approval1.8.1? → approval1.8.1+
This is in toolbar, but never got ported to Firefox.
Attachment #235098 - Flags: review?(provos)
Comment on attachment 235098 [details] [diff] [review]
v1: add first path to domain for checking

looks good
Attachment #235098 - Flags: review?(provos) → review+
Attachment #235098 - Flags: superreview?(bryner)
Attachment #235098 - Flags: superreview?(bryner) → superreview+
patch "use whitelist to suppress remote lookups" is on branch

patch "add first path to domain for checking" is on trunk
Attachment #235098 - Flags: approval1.8.1?
Please get new patch on trunk...
Whiteboard: [land on trunk]
(In reply to comment #8)
> Please get new patch on trunk...

New patch is on trunk (was landed 8-23).
Whiteboard: [land on trunk]
Whiteboard: [schrep-181approval pending]
Comment on attachment 235098 [details] [diff] [review]
v1: add first path to domain for checking

a=schrep/beltnzer for drivers.
Attachment #235098 - Flags: approval1.8.1? → approval1.8.1+
patch "add first path to domain for checking" on branch
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [schrep-181approval pending]
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: