348708 - "ASSERTION: same old and new parent frame" adding to optgroup

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jesse Ruderman]

###!!! ASSERTION: same old and new parent frame: 'aOldParentFrame != aNewParentFrame', file /Users/admin/trunk/mozilla/layout/generic/nsHTMLContainerFrame.cpp, line 489

I'm guessing that this is a regression, but I don't have a regression range.

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Jesse Ruderman]

I also see

###!!! ASSERTION: Potential deadlock between Monitor@bfffbc84 and XPCJSRuntime::mMapLockMonitor@212b500: 'Error', file /Users/admin/trunk/mozilla/xpcom/threads/nsAutoLock.cpp, line 302

when I load this testcase from Bugzilla and reload.  I don't know if that's related.

Comment 3

[Mats Palmgren (inactive)]

The assertion is harmless but noisy.
ReparentFrameViewList will return without any side-effects when
|newParent == parentFrame| and we will do redundant assignment 
after the call in nsCSSFrameConstructor.
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/generic/nsHTMLContainerFrame.cpp&rev=3.217&root=/cvsroot&mark=520#481

I don't see the second assertion (in comment 2) and I'm pretty sure
it's unrelated.

Comment 4

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 234524 [details] [diff] [review]
Patch rev. 1

Yeah, makes sense.

Comment 6

[Mats Palmgren (inactive)]

Checked in to trunk at 2006-08-21 19:29 PDT.

-> FIXED

Comment 7

[Jesse Ruderman]

Crashtest checked in.