348755 - No Context Menu For SVG

Status: NEW

(Firefox :: Menus, enhancement)

Description

[Doug Schepers]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6

There should be a bool for onSVG in the context menu interface.  This is not a request for special SVG context menu items (like zoom and pan) though that would be nice.  This is just a request that extension authors can find when the user has clicked on SVG content (either inline or as a reference).  This will be very useful for SVG specific menu items like zooming, panning, and rotating.


Reproducible: Always

Steps to Reproduce:
1. Build an extension
2. try to use the context menu to find out if the user clicked on SVG content.
3. fail.

Actual Results:  
no indication of presence of SVG

Expected Results:  
having available a boolean onSVG value in the context menu interface that reports the presence of SVG

In http://lxr.mozilla.org/seamonkey/source/browser/base/content/browser.js , there should be code something like this pseudocode:

function nsContextMenu( xulMenu ) {
 ...
 this.onSVG          = false;
}

nsContextMenu.prototype = {
 ...
 setTarget : function ( node, rangeParent, rangeOffset ) {
  ...
  // See if the user clicked on SVG
  const NS_SVG = "http://www.w3.org/2000/svg";
  if ((this.target.parentNode.namespaceURI == NS_SVG)
       || (this.target.namespaceURI == NS_SVG))
     this.onSVG = true;
 }
}

Comment 1

[Doug Schepers]

Attachment: Patch that adds onSVG bool to context menu

Patch that adds onSVG bool to context menu (like onImage or onMathML)... 
belongs in ~\Mozilla Firefox\chrome\browser.jar\content\browser 

Necessary for effective SVG-specific extensions.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: CVS diff of submitted file

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: patch with ifdefs, additional onSVGDoc and additional reset

Argh, sorry Doug. Completely forgot about this. Here's what I had which should preempt some of the reasons that may be given for r-. Requesting review for you too to speed this along.

Comment 4

[Jonathan Watt [:jwatt]]

Doug: I recommend you update the patch and change request review from another reviewer:

http://www.mozilla.org/projects/firefox/review.html

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 235887 [details] [diff] [review]
patch with ifdefs, additional onSVGDoc and additional reset

based on jwatt's comments, patch needs updating before review.  I'm getting back into the review slog, so feel free to request from me again.

Comment 6

[tor]

Attachment: update to tip