Closed Bug 348781 Opened 18 years ago Closed 18 years ago

Add 7-Zip SFX source to the tree

Categories

(Firefox :: Installer, defect)

Product:
Firefox
Component:
Installer
Version:
1.8 Branch
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

(Keywords: fixed1.8.0.7, fixed1.8.1)

Attachments

(5 files, 1 obsolete file)

zipped patch - just includes required files from 7-Zip source and our mods - checked in to trunk and MOZILLA_1_8_BRANCH
122.88 KB, application/zip
benjamin
: first-review+
dbaron
: approval1.8.1+
Details
changes made to the source
1.11 KB, patch
Details | Diff | Splinter Review
New 7zSD.sfx for Thunderbird - checked in to trunk, MOZILLA_1_8_0_BRANCH, and MOZILLA_1_8_BRANCH
104.00 KB, application/octet-stream
mscott
: first-review+
mscott
: approval-thunderbird2+
mscott
: approval1.8.0.7+
Details
New 7zSD.sfx for Sunbird - checked in to trunk and MOZILLA_1_8_BRANCH
104.00 KB, application/octet-stream
mattwillis
: first-review+
Details
New 7zSD.sfx for Firefox - checked in to trunk, MOZILLA_1_8_0_BRANCH, and MOZILLA_1_8_BRANCH
104.00 KB, application/octet-stream
dveditz
: approval1.8.0.7+
Details 
The latest 7-Zip SFX source has a silent config file option and we would also like to support our installer's silent command line argument.
Attached file New 7zSD.sfx for Firefox (obsolete) — 

    
    

    
  
Comment on attachment 233865 [details]
zipped patch - just includes required files from 7-Zip source and our mods - checked in to trunk and MOZILLA_1_8_BRANCH

There are a couple of stray tabs in this that I have fixed locally in my tree

        Attachment #233865 -
        Flags: first-review?(benjamin)

    
    

    
  
I should mention that compiling this with MSVC 8 prevented upx from successfully compressing the sfx so for now it should be compiled with MSVC 6. MSVC 6 also creates a smaller file by over 15 KB.

    
    

    
  
Comment on attachment 233865 [details]
zipped patch - just includes required files from 7-Zip source and our mods - checked in to trunk and MOZILLA_1_8_BRANCH

I'd like to land this on all the branches, unless you don't think that's a good idea for some reason.

        Attachment #233865 -
        Flags: first-review?(benjamin)

        Attachment #233865 -
        Flags: first-review+

        Attachment #233865 -
        Flags: approval1.8.1?

        Attachment #233865 -
        Flags: approval1.8.0.7?

    
    

    
  
Comment on attachment 233865 [details]
zipped patch - just includes required files from 7-Zip source and our mods - checked in to trunk and MOZILLA_1_8_BRANCH

a=dbaron on behalf of drivers.  Please land on MOZILLA_1_8_BRANCH and add the fixed1.8.1 keyword once you have done so.

        Attachment #233865 -
        Flags: approval1.8.1? → approval1.8.1+

    
    

    
  
Comment on attachment 233865 [details]
zipped patch - just includes required files from 7-Zip source and our mods - checked in to trunk and MOZILLA_1_8_BRANCH

Just a couple hours ago rstrong was asking about license issues and whether this code could be checked in. Please wait until those issues are addressed before renominating it.

        Attachment #233865 -
        Flags: approval1.8.0.7?

    
    

    
  
Checked the binary into MOZILLA_1_8_BRANCH. I'll check the binary into trunk after it opens. The source won't be checked in until after I receive the go ahead regarding the license issues.

        Attachment #233866 -
        Attachment description: New 7zSD.sfx → New 7zSD.sfx for Firefox

        Attachment #233866 -
        Flags: approval1.8.0.7?

        Attachment #234095 -
        Flags: first-review?(mattwillis) → first-review+

    
  

        Attachment #234094 -
        Flags: first-review?(mscott)

        Attachment #234094 -
        Flags: first-review+

        Attachment #234094 -
        Flags: approval-thunderbird2+

    
    

    
  
Checked in the Thunderbird and Sunbird binaries on the MOZILLA_1_8_BRANCH. I'll check them into trunk after it re-opens.

        Attachment #233866 -
        Attachment is obsolete: true

        Attachment #233866 -
        Flags: approval1.8.0.7?

    
    

    
  
Comment on attachment 234094 [details]
New 7zSD.sfx for Thunderbird - checked in to trunk, MOZILLA_1_8_0_BRANCH, and MOZILLA_1_8_BRANCH

triage team, if you decide to approve the firefox change for 1.8.0.7, we should approve the thunderbird change too so we can keep them consistent.

        Attachment #234094 -
        Flags: approval1.8.0.7+

        Attachment #234094 -
        Attachment description: New 7zSD.sfx for Thunderbird → New 7zSD.sfx for Thunderbird - checked in to trunk and MOZILLA_1_8_BRANCH

        Attachment #234109 -
        Attachment description: New 7zSD.sfx for Firefox → New 7zSD.sfx for Firefox - checked in to trunk and MOZILLA_1_8_BRANCH

        Attachment #234095 -
        Attachment description: New 7zSD.sfx for Sunbird → New 7zSD.sfx for Sunbird - checked in to trunk and MOZILLA_1_8_BRANCH

    
    

    
  
Only the binaries are checked in to trunk and MOZILLA_1_8_BRANCH
Whiteboard: [binaries only checked in]

    
    

    
  
Comment on attachment 234109 [details]
New 7zSD.sfx for Firefox - checked in to trunk, MOZILLA_1_8_0_BRANCH, and MOZILLA_1_8_BRANCH

approved for 1.8.0 branch, a=dveditz for drivers

        Attachment #234109 -
        Flags: approval1.8.0.7? → approval1.8.0.7+

    
    

    
  
Binaries checked in to MOZILLA_1_8_0_BRANCH for 1.8.0.7. They have also been checked in to trunk and MOZILLA_1_8_BRANCH. I have received the green light to check in the source and will try to do so this evening.
Keywords: fixed1.8.0.7

    
    

    
  
Source checked in to trunk and MOZILLA_1_8_BRANCH
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [binaries only checked in]

        Attachment #233865 -
        Attachment description: zipped patch - just includes required files from 7-Zip source and our mods → zipped patch - just includes required files from 7-Zip source and our mods - checked in to trunk and MOZILLA_1_8_BRANCH

        Attachment #234094 -
        Attachment description: New 7zSD.sfx for Thunderbird - checked in to trunk and MOZILLA_1_8_BRANCH → New 7zSD.sfx for Thunderbird - checked in to trunk, MOZILLA_1_8_0_BRANCH, and MOZILLA_1_8_BRANCH

        Attachment #234109 -
        Attachment description: New 7zSD.sfx for Firefox - checked in to trunk and MOZILLA_1_8_BRANCH → New 7zSD.sfx for Firefox - checked in to trunk, MOZILLA_1_8_0_BRANCH, and MOZILLA_1_8_BRANCH
Component: NSIS Installer → Installer
Product: Toolkit → Firefox

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: