Closed Bug 348784 Opened 18 years ago Closed 16 years ago

Bookmark and History sidebar "titles" have too much padding and is not aligned with "Search:" below each

Categories

(Firefox :: Theme, defect)

x86
Windows XP
defect
Not set
trivial

Tracking

()

VERIFIED FIXED
Firefox 3

People

(Reporter: BoxerBoi76, Assigned: kliu)

References

Details

(Keywords: polish)

Attachments

(3 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060815 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060815 BonEcho/2.0b1

Bookmark and History sidebar "titles" have too much padding and is not aligned with "Search:" below each

Reproducible: Always

Steps to Reproduce:
1) Launch FF
2) Toggle Bookmarks and/or History sidebars and observe that Bookmarks and or History have too much padding and is not aligned with "Search:" below each

Actual Results:  
Observe that Bookmarks and or History have too much padding and is not aligned with "Search:" below each

Expected Results:  
Bookmarks and or History have the correct padding and are aligned with "Search:" below each
Keywords: polish
Version: unspecified → 2.0 Branch
WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060817 BonEcho/2.0b1
(In reply to comment #2)
> WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060817
> BonEcho/2.0b1

Can you please provide a screenshot showing WFM in the default theme?

~B
(In reply to comment #2)
> WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060817
> BonEcho/2.0b1

Can you please provide a screenshot showing WFM in the default theme?

~B
I'm sorry, my bad. ;) I misunderstood your screenshots.  I can reproduce this in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060824 BonEcho/2.0b2 and Firefox 1.5.0.6.  
Status: UNCONFIRMED → NEW
Ever confirmed: true
This still exists in FF3.  Can we clean this up for release?
Flags: blocking-firefox3?
Component: Toolbars → Theme
Flags: blocking-firefox3? → blocking-firefox3-
QA Contact: toolbars → theme
Version: 2.0 Branch → Trunk
Blocks: 425582
Attached patch patchSplinter Review
Assignee: nobody → kliu.bugzilla.3c9f
Status: NEW → ASSIGNED
Attachment #318068 - Flags: ui-review?(beltzner)
Attachment #318068 - Flags: review?(gavin.sharp)
Attached image after screenshot
Whiteboard: [has patch][needs review gavin]
Comment on attachment 318068 [details] [diff] [review]
patch

It would probably be best to just remove http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/themes/winstripe/global/global.css&rev=1.13&mark=178-180#178 and fix this for everyone, but this is a safer fix at this point since it won't have any unintended side effects for other sidebarheader users.
Attachment #318068 - Flags: review?(gavin.sharp) → review+
URL: N/A
Whiteboard: [has patch][needs review gavin] → [has patch]
Comment on attachment 318068 [details] [diff] [review]
patch

a=beltzner for 1.9
Attachment #318068 - Flags: ui-review?(beltzner)
Attachment #318068 - Flags: ui-review+
Attachment #318068 - Flags: approval1.9+
Keywords: checkin-needed
mozilla/browser/themes/winstripe/browser/browser.css 	1.214 
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Whiteboard: [has patch]
Target Milestone: --- → Firefox 3
Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9) Gecko/2008051206 Firefox/3.0
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: