Closed
Bug 348786
Opened 18 years ago
Closed 18 years ago
Use JSCLASS_GLOBAL_FLAGS, and init Block class harder
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla1.8.1beta2
People
(Reporter: brendan, Assigned: brendan)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
5.09 KB,
patch
|
brendan
:
review+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
The two are related, oddly enough: certain "compilation scopes" for XUL and XBL, and old XPInstall's global, lack JSCLASS_GLOBAL_FLAGS. Yet with the latest patch for bug 336379, the compiler must be able to create Block objects for catch clause lexical scopes. But js_InitBlockClass calls were forgotten in the usual "eager class init" places (JS_InitStandardClasses, the big class-init tables that drive JS_ResolveStandardClass).
Patch next.
/be
|
Assignee | |
Comment 1•18 years ago
|
||
mrbkap is right here and says "r=me, mark it!".
/be
Attachment #233879 -
Flags: review+
|
|
Assignee | |
Updated•18 years ago
|
Status: NEW → ASSIGNED
Flags: blocking1.8.1?
|
|
Assignee | |
Comment 2•18 years ago
|
||
Cc'ing dveditz just cuz I touched xpinstall, to add JSCLASS_GLOBAL_FLAGS to the global object's class. This is a good optimization only.
/be
|
|
Assignee | |
Comment 3•18 years ago
|
||
Fixed on trunk.
/be
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 4•18 years ago
|
||
fine by me, moa=dveditz
|
||
Updated•18 years ago
|
Flags: in-testsuite-
|
||
Updated•18 years ago
|
Flags: blocking1.8.1? → blocking1.8.1+
|
|
||
Updated•18 years ago
|
Attachment #233879 -
Flags: approval1.8.1?
|
|
||
Comment 5•18 years ago
|
||
Comment on attachment 233879 [details] [diff] [review]
fix
a=beltzner on behalf of drivers, for landing on the MOZILLA_1_8_BRANCH. Please mark fixed1.8.1 when it lands.
Attachment #233879 -
Flags: approval1.8.1? → approval1.8.1+
You need to log in
before you can comment on or make changes to this bug.
Description
•