Closed Bug 348786 Opened 14 years ago Closed 14 years ago

Use JSCLASS_GLOBAL_FLAGS, and init Block class harder

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.8.1beta2

People

(Reporter: brendan, Assigned: brendan)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

The two are related, oddly enough: certain "compilation scopes" for XUL and XBL, and old XPInstall's global, lack JSCLASS_GLOBAL_FLAGS.  Yet with the latest patch for bug 336379, the compiler must be able to create Block objects for catch clause lexical scopes.  But js_InitBlockClass calls were forgotten in the usual "eager class init" places (JS_InitStandardClasses, the big class-init tables that drive JS_ResolveStandardClass).

Patch next.

/be
Attached patch fix Splinter Review
mrbkap is right here and says "r=me, mark it!".

/be
Attachment #233879 - Flags: review+
Status: NEW → ASSIGNED
Flags: blocking1.8.1?
Cc'ing dveditz just cuz I touched xpinstall, to add JSCLASS_GLOBAL_FLAGS to the global object's class.  This is a good optimization only.

/be
Fixed on trunk.

/be
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
fine by me, moa=dveditz
Flags: in-testsuite-
Flags: blocking1.8.1? → blocking1.8.1+
Comment on attachment 233879 [details] [diff] [review]
fix 

a=beltzner on behalf of drivers, for landing on the MOZILLA_1_8_BRANCH. Please mark fixed1.8.1 when it lands.
Attachment #233879 - Flags: approval1.8.1? → approval1.8.1+
Fixed on the 1.8 branch too.

/be
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.