348804 - in-param for nsMsgKeyArray.h breaks obj-c build for embedded applications.

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Nick Kreeger]

In msMsgKeyArray.h the following method is defined:

PRUint32 Add(nsMsgKey id) { ...

The problem with this is that |id| is a reserved keyword in objective-c, thus breaking any embedding support for cocoa applications.

Comment 1

[Nick Kreeger]

Attachment: Proposed patch.

Here is a patch to fix this problem

Comment 2

[Håkan Waara]

Comment on attachment 233928 [details] [diff] [review]
Proposed patch.

r=me on anything besides "id" for the var name. :)

If the mailnews maintainers has some preference for the var name, I defer to them.

Comment 3

[David :Bienvenu]

Comment on attachment 233928 [details] [diff] [review]
Proposed patch.

I'd prefer key. As long as that's OK, I'll change it to key and check that in...

Comment 4

[Nick Kreeger]

It doesn't matter to me, I can check it in if you want with "key" (i have CVS access).

Comment 5

[David :Bienvenu]

oh, ok, Nick, go ahead and check it in with key. If you need this on the 2.0 branch, you can land it there as well, or if you don't have a branch tree, I can do that.

Comment 6

[Nick Kreeger]

Checked in to MOZILLA_1_8_BRANCH, waiting for my machine to spin a trunk build before i land it there.

Comment 7

[Nick Kreeger]

Fixed trunk.

Comment 8

[Frank Wein [:mcsmurf]]

I don't want to nitpick too much, but isn't approval1.8.1 needed these days for patches that go on the 1.8 branch (ok, I know, small patch, mailnews/-only, but still) :)?

Comment 9

[Nick Kreeger]

(In reply to comment #8)
> I don't want to nitpick too much, but isn't approval1.8.1 needed these days for
> patches that go on the 1.8 branch (ok, I know, small patch, mailnews/-only, but
> still) :)?
> 

"If you need this on the 2.0
branch, you can land it there as well, or if you don't have a branch tree, I
can do that."

I understand, but since I was given the go ahead for 2.0 (1.8) i landed it, my bad.

Comment 10

[Frank Wein [:mcsmurf]]

If bienvenu has told you that you can checkin on 1.8 branch it's ok I guess (at least not your "fault" then :)...