348820 - Fix followups from bug 346942

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Jeff Walden [:Waldo]]

https://bugzilla.mozilla.org/show_bug.cgi?id=346942#c27

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch (hits followups, changes UI as desired

This hits the followups mentioned in the URL in the original report.  It also changes the UI as desired by cbeard.

Fiddle around with this UI and tell me how you like the interactions -- does this work?

Comment 2

[Jeff Walden [:Waldo]]

This has l10n impact and is desired by per bug 346942 comment 33.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 234165 [details] [diff] [review]
Patch (hits followups, changes UI as desired

Looks good, two small nits:

1. s/I do accept/I accept/

2. can you make the dialog a little longer so we don't need the scrollbar on
mac? Right now you're off by about 1.5 lines ...

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: showing the slightly too short window on mac

Comment 5

[Jeff Walden [:Waldo]]

(In reply to comment #3)
> Looks good, two small nits:

Sure, I can pick these up easily with some entity changes and name bumps.

Comment 6

[Jeff Walden [:Waldo]]

Attachment: Fixes ui-r nits, removes some cruft

This fixes beltzner's nits, and it removes some old code that's no longer needed or used in the patch.  UI's still the same, tho, modulo those nits, so carrying over ui-r...

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 234366 [details] [diff] [review]
Fixes ui-r nits, removes some cruft

nit: fix the alignment in phishEULA.dtd that changed when you changed ent names, otherwise looks good to go!

Comment 8

[Jeff Walden [:Waldo]]

Comment on attachment 234366 [details] [diff] [review]
Fixes ui-r nits, removes some cruft

Patch is in on trunk; need on branch because it affects l10n, handles privacy agreement load failure better.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 234366 [details] [diff] [review]
Fixes ui-r nits, removes some cruft

a=beltzner on behalf of drivers, please land on MOZILLA_1_8_BRANCH and mark fixed.

Also, address mconnor's alignment nit as you check it in.

Comment 10

[Jeff Walden [:Waldo]]

Patch in on branch.