If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix followups from bug 346942

RESOLVED FIXED in Firefox 2 beta2

Status

()

Firefox
Preferences
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

({fixed1.8.1, late-l10n})

Trunk
Firefox 2 beta2
fixed1.8.1, late-l10n
Points:
---
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

https://bugzilla.mozilla.org/show_bug.cgi?id=346942#c27
Created attachment 234165 [details] [diff] [review]
Patch (hits followups, changes UI as desired

This hits the followups mentioned in the URL in the original report.  It also changes the UI as desired by cbeard.

Fiddle around with this UI and tell me how you like the interactions -- does this work?
Attachment #234165 - Flags: ui-review?(beltzner)
Attachment #234165 - Flags: review?(mconnor)
This has l10n impact and is desired by per bug 346942 comment 33.
Status: NEW → ASSIGNED
Flags: blocking-firefox2?
Keywords: late-l10n
Comment on attachment 234165 [details] [diff] [review]
Patch (hits followups, changes UI as desired

Looks good, two small nits:

1. s/I do accept/I accept/

2. can you make the dialog a little longer so we don't need the scrollbar on
mac? Right now you're off by about 1.5 lines ...
Attachment #234165 - Flags: ui-review?(beltzner) → ui-review+
Flags: blocking-firefox2? → blocking-firefox2+
Created attachment 234261 [details]
showing the slightly too short window on mac
(In reply to comment #3)
> Looks good, two small nits:

Sure, I can pick these up easily with some entity changes and name bumps.
Created attachment 234366 [details] [diff] [review]
Fixes ui-r nits, removes some cruft

This fixes beltzner's nits, and it removes some old code that's no longer needed or used in the patch.  UI's still the same, tho, modulo those nits, so carrying over ui-r...
Attachment #234165 - Attachment is obsolete: true
Attachment #234366 - Flags: ui-review+
Attachment #234366 - Flags: review?(mconnor)
Attachment #234165 - Flags: review?(mconnor)
Comment on attachment 234366 [details] [diff] [review]
Fixes ui-r nits, removes some cruft

nit: fix the alignment in phishEULA.dtd that changed when you changed ent names, otherwise looks good to go!
Attachment #234366 - Flags: review?(mconnor) → review+

Updated

11 years ago
Whiteboard: [checkin needed]
Comment on attachment 234366 [details] [diff] [review]
Fixes ui-r nits, removes some cruft

Patch is in on trunk; need on branch because it affects l10n, handles privacy agreement load failure better.
Attachment #234366 - Flags: approval1.8.1?
Whiteboard: [checkin needed]
Comment on attachment 234366 [details] [diff] [review]
Fixes ui-r nits, removes some cruft

a=beltzner on behalf of drivers, please land on MOZILLA_1_8_BRANCH and mark fixed.

Also, address mconnor's alignment nit as you check it in.
Attachment #234366 - Flags: approval1.8.1? → approval1.8.1+
Patch in on branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.