The default bug view has changed. See this FAQ.

Adding missing id's to <menupopup> elements in viewSource.xul viewPartialSource.xul viewSourceOverlay.xul

RESOLVED FIXED in seamonkey1.1alpha

Status

SeaMonkey
UI Design
--
enhancement
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

({fixed-seamonkey1.1})

Trunk
seamonkey1.1alpha
fixed-seamonkey1.1

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

2.04 KB, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
Robert Kaiser
: approval-seamonkey1.1+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
I need these IDs as the JSView extension (ported from Firefox to SeaMonkey) needs these to successfully overlay the view source windows.

Patch coming up.
(Assignee)

Comment 1

11 years ago
Created attachment 234010 [details] [diff] [review]
Patch v1.0

I didn't fix the trailing whitespace nit in this patch. Should I?
(Assignee)

Comment 2

11 years ago
Comment on attachment 234010 [details] [diff] [review]
Patch v1.0

obvious one-liners, asking for r/sr
Attachment #234010 - Flags: superreview?(neil)
Attachment #234010 - Flags: review?(neil)

Updated

11 years ago
Attachment #234010 - Flags: superreview?(neil)
Attachment #234010 - Flags: superreview+
Attachment #234010 - Flags: review?(neil)
Attachment #234010 - Flags: review+

Comment 3

11 years ago
--> Philip
Assignee: guifeatures → philip.chee
(Assignee)

Updated

11 years ago
Whiteboard: [checkin needed]
(Assignee)

Comment 4

11 years ago
gavin says on #irc "I will notice it quicker if I get bugmail"
mozilla/xpfe/browser/resources/content/viewSource.xul 	1.57
mozilla/xpfe/browser/resources/content/viewPartialSource.xul 	1.8
mozilla/xpfe/browser/resources/content/viewSourceOverlay.xul 	1.28
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → seamonkey1.1alpha
Comment on attachment 234010 [details] [diff] [review]
Patch v1.0

first-a = me for seamonkey 1.1 final, need one more
Attachment #234010 - Flags: approval-seamonkey1.1?

Comment 7

11 years ago
Comment on attachment 234010 [details] [diff] [review]
Patch v1.0

a=me for SeaMonkey 1.1
Attachment #234010 - Flags: approval-seamonkey1.1? → approval-seamonkey1.1+

Comment 8

11 years ago
Landed on MOZILLA_1_8_BRANCH.

Updated

11 years ago
Keywords: fixed-seamonkey1.1

Updated

9 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.