348856 - Adding missing id's to <menupopup> elements in viewSource.xul viewPartialSource.xul viewSourceOverlay.xul

Status: RESOLVED FIXED

Description

[Philip Chee]

I need these IDs as the JSView extension (ported from Firefox to SeaMonkey) needs these to successfully overlay the view source windows.

Patch coming up.

Comment 1

[Philip Chee]

Created attachment 234010 [details] [diff] [review]
Patch v1.0

I didn't fix the trailing whitespace nit in this patch. Should I?

Comment 2

[Philip Chee]

Comment on attachment 234010 [details] [diff] [review]
Patch v1.0

obvious one-liners, asking for r/sr

Comment 3

[Stefan [:stefanh]]

--> Philip

Comment 4

[Philip Chee]

gavin says on #irc "I will notice it quicker if I get bugmail"

Comment 5

[:Gavin Sharp [email: [e-mail]]]

mozilla/xpfe/browser/resources/content/viewSource.xul 	1.57
mozilla/xpfe/browser/resources/content/viewPartialSource.xul 	1.8
mozilla/xpfe/browser/resources/content/viewSourceOverlay.xul 	1.28

Comment 6

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 234010 [details] [diff] [review]
Patch v1.0

first-a = me for seamonkey 1.1 final, need one more

Comment 7

[Robert Kaiser]

Comment on attachment 234010 [details] [diff] [review]
Patch v1.0

a=me for SeaMonkey 1.1

Comment 8

[Karsten Düsterloh]

Landed on MOZILLA_1_8_BRANCH.