Closed Bug 348856 Opened 16 years ago Closed 16 years ago

Adding missing id's to <menupopup> elements in viewSource.xul viewPartialSource.xul viewSourceOverlay.xul

Categories

(SeaMonkey :: UI Design, enhancement)

Product:
SeaMonkey
Component:
UI Design
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
seamonkey1.1alpha

People

(Reporter: philip.chee, Assigned: philip.chee)

References

(
URL
)

Details

(Keywords: fixed-seamonkey1.1)

Attachments

(1 file)

Patch v1.0
2.04 KB, patch
neil
: review+
neil
: superreview+
kairo
: approval-seamonkey1.1+
Details | Diff | Splinter Review 
I need these IDs as the JSView extension (ported from Firefox to SeaMonkey) needs these to successfully overlay the view source windows.

Patch coming up.
Attached patch Patch v1.0 — — Splinter Review 
I didn't fix the trailing whitespace nit in this patch. Should I?
Comment on attachment 234010 [details] [diff] [review]
Patch v1.0

obvious one-liners, asking for r/sr
Attachment #234010 - Flags: superreview?(neil)
Attachment #234010 - Flags: review?(neil)
Attachment #234010 - Flags: superreview?(neil)
Attachment #234010 - Flags: superreview+
Attachment #234010 - Flags: review?(neil)
Attachment #234010 - Flags: review+
--> Philip
Assignee: guifeatures → philip.chee
Whiteboard: [checkin needed]
gavin says on #irc "I will notice it quicker if I get bugmail"
mozilla/xpfe/browser/resources/content/viewSource.xul 	1.57
mozilla/xpfe/browser/resources/content/viewPartialSource.xul 	1.8
mozilla/xpfe/browser/resources/content/viewSourceOverlay.xul 	1.28
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → seamonkey1.1alpha
Comment on attachment 234010 [details] [diff] [review]
Patch v1.0

first-a = me for seamonkey 1.1 final, need one more
Attachment #234010 - Flags: approval-seamonkey1.1?
Comment on attachment 234010 [details] [diff] [review]
Patch v1.0

a=me for SeaMonkey 1.1
Attachment #234010 - Flags: approval-seamonkey1.1? → approval-seamonkey1.1+
Landed on MOZILLA_1_8_BRANCH.
Keywords: fixed-seamonkey1.1
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.