Closed Bug 348923 Opened 13 years ago Closed 13 years ago

Clean up a few more variable-scoping issues for mod_perl

Categories

(Bugzilla :: Bugzilla-General, defect)

2.23
defect
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: mkanat, Assigned: mkanat)

References

Details

Attachments

(1 file)

Right now when I start up my mod_perl installation, it says:

> Variable "$bug" will not stay shared at /var/www/html/mod_perl/process_bug.cgi line 716.
> Variable "$PrivilegesRequired" will not stay shared at /var/www/html/mod_perl/process_bug.cgi line 717.
> Variable "$realdepth" will not stay shared at /var/www/html/mod_perl/showdependencytree.cgi line 116.
> Variable "$user" will not stay shared at /var/www/html/mod_perl/showdependencytree.cgi line 123.
> Variable "$maxdepth" will not stay shared at /var/www/html/mod_perl/showdependencytree.cgi line 132.
> Variable "$hide_resolved" will not stay shared at /var/www/html/mod_perl/showdependencytree.cgi line 133.

Those all need to be fixed.
Flags: blocking3.0?
Flags: blocking3.0? → blocking3.0+
Attached patch v1Splinter Review
Okay, so it turns out that the above errors break edit-multiple on mod_perl.

This patch at least fixes edit-multiple. I haven't tested it much more than that.
Assignee: general → mkanat
Status: NEW → ASSIGNED
Attachment #241385 - Flags: review?(LpSolit)
Attachment #241385 - Flags: review?(LpSolit) → review?(justdave)
Comment on attachment 241385 [details] [diff] [review]
v1

>+        ChangeResolution($bug, '');

This is ugly. :) I suppose $bug->change_resolution('') would be better, but that's another story (when Bug.pm will be able to update data itself).

I only checked that this patch doesn't break anything. I didn't check that you caught all variables which need to use "our" instead of "my". r=LpSolit
Attachment #241385 - Flags: review?(justdave) → review+
Flags: approval?
Flags: approval? → approval+
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.345; previous revision: 1.344
done
Checking in showdependencytree.cgi;
/cvsroot/mozilla/webtools/bugzilla/showdependencytree.cgi,v  <--  showdependencytree.cgi
new revision: 1.49; previous revision: 1.48
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.