349049 - subscribe to feed cancel confirmation dialog (sheet) comes up after parent window closed

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Asa Dotzler [:asa]]

A user can close the subscribe to a feed window and end up with a parentless confirmation dialog. 

Steps.
1. attempt to subscribe to a feed we can't parse.
   http://rss.pubsub.com/eb/53/61727204d3efd03cca61749721.xml
2. while the subscribe window is stalled confirming the feed, close the subscribe window.
3. wait a few seconds.

Results: you get a "Are you sure you wish to cancel subscribing" confirmation dialog that's missing it's parent so it's just an immovable floating sheet that's not modal to anything (and so can get easily lost behind the main mail window).

Expected results:  When you attempt to close the subscribe window, you should get a window modal confirmation dialog (sheet) first and only after selecting "Yes", should the subscribe window be torn down.  Selecting "No" should return you to the subscribe window.

Comment 1

[Asa Dotzler [:asa]]

Attachment: screenshot showing the parentless sheet

This is tested with today's UB Thunderbird 2 build on an Intel Mac.

Comment 2

[alta88]

the code doesn't even have anything in place to actually cancel either, so it's a false dialog.

Comment 3

[alta88]

Attachment: patch

fix the premature dialog close and make cancel work.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 760209 [details] [diff] [review]
patch

Review of attachment 760209 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx. r=mkmelin

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/c1f0796a0baa