subscribe to feed cancel confirmation dialog (sheet) comes up after parent window closed

RESOLVED FIXED in Thunderbird 24.0

Status

MailNews Core
Feed Reader
--
minor
RESOLVED FIXED
11 years ago
4 years ago

People

(Reporter: asa, Assigned: alta88)

Tracking

unspecified
Thunderbird 24.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
A user can close the subscribe to a feed window and end up with a parentless confirmation dialog. 

Steps.
1. attempt to subscribe to a feed we can't parse.
   http://rss.pubsub.com/eb/53/61727204d3efd03cca61749721.xml
2. while the subscribe window is stalled confirming the feed, close the subscribe window.
3. wait a few seconds.

Results: you get a "Are you sure you wish to cancel subscribing" confirmation dialog that's missing it's parent so it's just an immovable floating sheet that's not modal to anything (and so can get easily lost behind the main mail window).

Expected results:  When you attempt to close the subscribe window, you should get a window modal confirmation dialog (sheet) first and only after selecting "Yes", should the subscribe window be torn down.  Selecting "No" should return you to the subscribe window.
(Reporter)

Comment 1

11 years ago
Created attachment 234265 [details]
screenshot showing the parentless sheet

This is tested with today's UB Thunderbird 2 build on an Intel Mac.

Updated

9 years ago
Assignee: mscott → nobody
Severity: normal → minor
(Assignee)

Comment 2

4 years ago
the code doesn't even have anything in place to actually cancel either, so it's a false dialog.
Component: Mail Window Front End → Feed Reader
OS: Mac OS X → All
Product: Thunderbird → MailNews Core
Hardware: x86 → All
Version: 2.0 → unspecified
(Assignee)

Comment 3

4 years ago
Created attachment 760209 [details] [diff] [review]
patch


fix the premature dialog close and make cancel work.
Attachment #760209 - Flags: review?(mkmelin+mozilla)

Comment 4

4 years ago
Comment on attachment 760209 [details] [diff] [review]
patch

Review of attachment 760209 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx. r=mkmelin
Attachment #760209 - Flags: review?(mkmelin+mozilla) → review+

Updated

4 years ago
Assignee: nobody → alta88
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/c1f0796a0baa
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.