349066 - Venkman's Open Windows view misconstructs base URL for urls like http://foo.com/#bar

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[:Gijs (he/him)]

Steps to reproduce:

1. Open http://archer.homeunix.org/temp/#foobar
2. Open the files list for the tab with this url.

Actual Result:
It shows http://archer.homeunix.org/temp/#foobartest.js

Expected Result:
It should show http://archer.homeunix.org/temp/test.js (or perhaps just test.js)

I'll try to get this in for my SoC thing, I'll have time to hack on it by Sunday.

Comment 1

[:Gijs (he/him)]

Attachment: Patch

Requiring at least one non-questionmark non-hash non-slash character after the last slash found just screws the regexp up on urls without such a thing.

Without it, it still won't match anything but the last slash because of the third part of the regular expression, which requires the end of the url, or a hash or a questionmark, which will never appear before the last slash. Or such was my idea, anyway.

Comment 2

[:Gijs (he/him)]

Oh, and obviously I tested this myself just as well, and the patch does indeed fix this issue afaict.

Comment 3

[:Gijs (he/him)]

Checked in -> FIXED