Closed
Bug 349283
Opened 18 years ago
Closed 18 years ago
"let" statement in "with" block crashes [@ js_Interpret]
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla1.8.1
People
(Reporter: jruderman, Assigned: mrbkap)
References
Details
(Keywords: crash, testcase, verified1.8.1)
Crash Data
Attachments
(3 files, 1 obsolete file)
|
47 bytes,
text/html
|
Details | |
|
894 bytes,
patch
|
brendan
:
review+
|
Details | Diff | Splinter Review |
|
1.49 KB,
patch
|
brendan
:
review+
|
Details | Diff | Splinter Review |
This crashes Firefox:
with({b:2}) {
let c = 3;
}
|
Reporter | |
Comment 1•18 years ago
|
||
|
Assignee | |
Comment 2•18 years ago
|
||
Argh! We fixed PushLexicalScope, but not its inlining in the let declaration case.
|
|
Assignee | |
Updated•18 years ago
|
OS: Mac OS X 10.4 → All
Priority: -- → P1
Hardware: Macintosh → All
Target Milestone: --- → mozilla1.8.1
|
||
Comment 3•18 years ago
|
||
Comment on attachment 234549 [details] [diff] [review]
Fix
Oy. I didn't remember the inlining. Mebbe we should macroize the node init code?
This would be a safe pick-up for beta 2.
/be
Attachment #234549 -
Flags: review?(brendan)
Attachment #234549 -
Flags: review+
Attachment #234549 -
Flags: approval1.8.1?
|
|
||
Comment 4•18 years ago
|
||
Oops, nm the beta 2 talk -- this regressed only on the trunk.
/be
Blocks: js1.7let
Flags: blocking1.8.1?
|
|
Assignee | |
Comment 5•18 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•18 years ago
|
||
let expressions were broken too.
Attachment #234554 -
Flags: review?(brendan)
|
|
Assignee | |
Comment 7•18 years ago
|
||
Attachment #234554 -
Attachment is obsolete: true
Attachment #234557 -
Flags: review?(brendan)
Attachment #234554 -
Flags: review?(brendan)
|
|
||
Comment 8•18 years ago
|
||
Comment on attachment 234557 [details] [diff] [review]
Better more let fixing
Yay, thanks.
/be
Attachment #234557 -
Flags: review?(brendan) → review+
|
|
Assignee | |
Updated•18 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 9•18 years ago
|
||
Fixed on trunk, I checked in for Blake so he could get some sleep.
/be
Status: REOPENED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
|
|
||
Comment 10•18 years ago
|
||
*** Bug 349290 has been marked as a duplicate of this bug. ***
|
||
Updated•18 years ago
|
Flags: blocking1.8.1? → blocking1.8.1+
|
||
Comment 11•18 years ago
|
||
Comment on attachment 234549 [details] [diff] [review]
Fix
Clearing the flag based on comment 4. Please re-nom if that is not correct.
Attachment #234549 -
Flags: approval1.8.1?
|
|
||
Updated•18 years ago
|
Flags: blocking1.8.1+
I'm actually going to renominate this per mrbkap -- for 1.8.1final -- since although the changes that caused this haven't yet landed on the 1.8 branch, they're supposed to land there before final.
Flags: blocking1.8.1?
|
||
Comment 13•18 years ago
|
||
Checking in regress-349283.js;
/cvsroot/mozilla/js/tests/js1_7/block/regress-349283.js,v <-- regress-349283.js
initial revision: 1.1
Flags: in-testsuite+
|
|
||
Updated•18 years ago
|
Flags: blocking1.8.1? → blocking1.8.1+
|
|
||
Comment 15•18 years ago
|
||
So does this need to land on 1.8.1?
|
|
||
Comment 16•18 years ago
|
||
This landed as part of the deferred landing of lexical and destructuring catch variables, bug 336379.
/be
Keywords: fixed1.8.1
|
|
||
Comment 17•18 years ago
|
||
verified fixed 1.8 20060914 windows/mac 1.9 20060914 windows/mac*/linux
Keywords: fixed1.8.1 → verified1.8.1
|
||
Updated•13 years ago
|
Crash Signature: [@ js_Interpret]
You need to log in
before you can comment on or make changes to this bug.
Description
•