349322 - calMonthGridPrinter.js outputs invalid and ugly css

Status: RESOLVED FIXED

(Calendar :: Printing, defect)

Description

[Matthew (lilmatt) Willis]

The HTML that calMonthGridPrinter creates has ugly, in some cases invalid, and difficult to read CSS.

Comment 1

[Matthew (lilmatt) Willis]

Taking.

Comment 2

[Matthew (lilmatt) Willis]

Attachment: rev0 - cleans up CSS

This patch:
  - normalizes all css to use lowercase
  - adds spaces to make things more readable
  - replaces "background" with "background-color" when only a colour is defined
  - doesn't attempt to include a border on events if the event has no category, or the category has no color assigned

Comment 3

[Joey Minta]

Comment on attachment 234596 [details] [diff] [review]
rev0 - cleans up CSS

-            var catColor;
+            var catColor = "";
             try {
                 catColor = pb2.getCharPref("calendar.category.color."+item.getProperty("CATEGORIES").toLowerCase());
             } catch(ex) {}
 
-            var style = 'font-size:11px; background-color:' + calColor + 
-                        '; border: solid ' + catColor + ' 2px;';
+            var style = 'font-size: 11px; background-color: ' + calColor + ';';
+            if (catColor != "") {
+                style += ' border: solid ' + catColor + ' 2px;';
+            }
This looks like there's more than just style cleanup here.  Why are switching from null to an empty string here?

Comment 4

[Matthew (lilmatt) Willis]

Attachment: rev1 - no more empty string

Fixes jminta's nit per IRC chat

Comment 5

[Joey Minta]

Comment on attachment 234810 [details] [diff] [review]
rev1 - no more empty string

r2=jminta

Comment 6

[Simon Paquet [:sipaq]]

I will only be able to review this on Monday at the earliest. If that is fine with you then leave the request as it is, if you don't want to wait so long, please move it to another reviewer.

Comment 7

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED