349323 - profile-startup listener leaked

Status: RESOLVED WONTFIX

(SeaMonkey :: UI Design, defect)

Description

[Andrew Schultz]

After bug 343602, nye reports that nsUpdateNotifier profile-startup listener gets leaked.

Neil said "probably because nsUpdateNotifier is a global rather than a constructor".

Update notifier is going away on trunk, so this only relevant for branch.

Comment 1

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> After bug 343602, nye reports that nsUpdateNotifier profile-startup listener
> gets leaked.

Now,
'Linux nye Dep bloat' is on (1.9) trunk,
no 'Mozilla1.8-SeaMonkey' box reports leaks :-(

> Update notifier is going away on trunk, so this only relevant for branch.

This file was removed from 1.9(.0) trunk:
<http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/xpfe/components/updates/src/nsUpdateNotifier.js&mark=1.13>
{{
1.13    kairo%kairo.at  2008-05-02 10:34                cvs remove the xpfe
files obsoleted by the recent checkin for bug 383085 which had r=mento,
r/sr=Neil via IRC for cvs removal (files are unused now)
}}

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <nsUpdateNotifier.js>

(In reply to comment #0)
> Neil said "probably because nsUpdateNotifier is a global rather than a
> constructor".

I don't know much about that.

But I think removing (all) observers should be an improvement/fix,
even if I don't know how to test the (leak) result.

Comment 3

[[e-mail]]

Somehow I doubt we'd take a leak fix on branch, especially without a way of checking for the leak.

I'm not sure why I might have thought that nsUpdateNotifier being a global would make any difference.

I have a hunch that the code doesn't actually need to keep a reference to the timer, thus avoiding all the fiddling about with shutdown observers.

Comment 4

[Serge Gautherie (:sgautherie)]

R.WontFix per previous comments.