[FIX]Crash [@ inDOMView::ContentRemoved] when removing root node from document

RESOLVED FIXED in mozilla1.9alpha

Status

Other Applications
DOM Inspector
P1
critical
RESOLVED FIXED
12 years ago
7 years ago

People

(Reporter: Martijn Wargers (zombie), Assigned: bz)

Tracking

({crash, regression})

unspecified
mozilla1.9alpha
crash, regression

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
To reproduce:
- Open dom inspector
- Select a document to inspect
- Remove the root node

Result: crash

Talkback ID: TB22290297Q
inDOMView::ContentRemoved   nsNodeUtils::ContentRemoved   nsGenericElement::doRemoveChildAt   nsDocument::RemoveChildAt   nsGenericElement::doRemoveChild   nsDocument::RemoveChild   XPCWrappedNative::CallMethod  

This regressed between 2006-05-17 and 2006-05-15, probably a regression from bug  285204
Created attachment 234790 [details] [diff] [review]
Fix

Stupid mistake... I really wish we'd pass a sane container around.  ;)
Assignee: dom-inspector → bzbarsky
Status: NEW → ASSIGNED
Attachment #234790 - Flags: superreview?(bugmail)
Attachment #234790 - Flags: review?(bugmail)
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Summary: Crash [@ inDOMView::ContentRemoved] when removing root node from document → [FIX]Crash [@ inDOMView::ContentRemoved] when removing root node from document
Target Milestone: --- → mozilla1.9alpha
Comment on attachment 234790 [details] [diff] [review]
Fix

Use the NODE_FROM macro from nsINode.h

I hope that we can convert a bunch of these nsIContent/nsIDocument pairs at some point to simple nsINode arguments.
Attachment #234790 - Flags: superreview?(bugmail)
Attachment #234790 - Flags: superreview+
Attachment #234790 - Flags: review?(bugmail)
Attachment #234790 - Flags: review+
Fixed, using NODE_FROM.  And yeah, that would be really nice.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
QA Contact: timeless → dom-inspector
Crash Signature: [@ inDOMView::ContentRemoved]
You need to log in before you can comment on or make changes to this bug.