Closed
Bug 349398
Opened 19 years ago
Closed 19 years ago
[FIX]Crash [@ inDOMView::ContentRemoved] when removing root node from document
Categories
(Other Applications :: DOM Inspector, defect, P1)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9alpha
People
(Reporter: martijn.martijn, Assigned: bzbarsky)
References
Details
(Keywords: crash, regression)
Crash Data
Attachments
(1 file)
|
1.61 KB,
patch
|
sicking
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
To reproduce:
- Open dom inspector
- Select a document to inspect
- Remove the root node
Result: crash
Talkback ID: TB22290297Q
inDOMView::ContentRemoved nsNodeUtils::ContentRemoved nsGenericElement::doRemoveChildAt nsDocument::RemoveChildAt nsGenericElement::doRemoveChild nsDocument::RemoveChild XPCWrappedNative::CallMethod
This regressed between 2006-05-17 and 2006-05-15, probably a regression from bug 285204
|
Assignee | |
Comment 1•19 years ago
|
||
Stupid mistake... I really wish we'd pass a sane container around. ;)
Assignee: dom-inspector → bzbarsky
Status: NEW → ASSIGNED
Attachment #234790 -
Flags: superreview?(bugmail)
Attachment #234790 -
Flags: review?(bugmail)
|
|
Assignee | |
Updated•19 years ago
|
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Summary: Crash [@ inDOMView::ContentRemoved] when removing root node from document → [FIX]Crash [@ inDOMView::ContentRemoved] when removing root node from document
Target Milestone: --- → mozilla1.9alpha
Comment on attachment 234790 [details] [diff] [review]
Fix
Use the NODE_FROM macro from nsINode.h
I hope that we can convert a bunch of these nsIContent/nsIDocument pairs at some point to simple nsINode arguments.
Attachment #234790 -
Flags: superreview?(bugmail)
Attachment #234790 -
Flags: superreview+
Attachment #234790 -
Flags: review?(bugmail)
Attachment #234790 -
Flags: review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Fixed, using NODE_FROM. And yeah, that would be really nice.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•18 years ago
|
QA Contact: timeless → dom-inspector
|
||
Updated•14 years ago
|
Crash Signature: [@ inDOMView::ContentRemoved]
You need to log in
before you can comment on or make changes to this bug.
Description
•