349409 - Make suiterunner use *stripe's global/ files

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Stefan [:stefanh]]

It seems that we're first adding the stripe's files to classic.jar and then overwriting them at a later stage with files from classic/global/*

Comment 1

[Stefan [:stefanh]]

Attachment: Don't add files from classic/global

Comment 2

[Robert Kaiser]

Comment on attachment 234664 [details] [diff] [review]
Don't add files from classic/global

As long as we're not needing those files from anywhere else in the tree or for the files still blocking bug 336874 this looks good to me. I still have to test before marking r+ but I think it might even be good to break stuff in suiterunner where we rely on theming not available in *stripe global, so we see what we still need to change.

Comment 3

[Robert Kaiser]

Comment on attachment 234664 [details] [diff] [review]
Don't add files from classic/global

OK, seems to work.

Now we just should make native theming more native so that e.g. groupboxes look like they should even in GTK2 or WinClassic, not only in WinXP Luna :)

Comment 4

[Stefan [:stefanh]]

Neil, can you take a look at this, please?

Comment 5

[Stefan [:stefanh]]

Checking in jar.mn;
/cvsroot/mozilla/themes/classic/jar.mn,v  <--  jar.mn
new revision: 1.161; previous revision: 1.160
done