update MOZILLA_USE_EXTENDED_FT2LIB

VERIFIED FIXED

Status

Core Graveyard
GFX: OS/2
VERIFIED FIXED
11 years ago
9 years ago

People

(Reporter: Andy Willis (abwillis), Assigned: Andy Willis (abwillis))

Tracking

({verified1.8.1.2})

Trunk
Other
OS/2
verified1.8.1.2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
The latest release of Innowin Font Engine now will use HKLM so there may not be a HKCU field or even if there is SM/FF/ETC may not be in it but in HKLM instead.  
Patch to follow that should take care of either case.
(Assignee)

Comment 1

11 years ago
Created attachment 234705 [details] [diff] [review]
Add HKLM check

Comment 2

11 years ago
Comment on attachment 234705 [details] [diff] [review]
Add HKLM check

>     // Is FT2LIB enabled?
>     HKEY key;
>     LONG result = RegOpenKeyEx(HKEY_CURRENT_USER,
>                                "Software\\Innotek\\InnoTek Font Engine", 0,
>                                KEY_READ, &key);
>     if (result != ERROR_SUCCESS) {
>-      DosFreeModule(hmod);
>-      return PR_FALSE;
>+      LONG result = RegOpenKeyEx(HKEY_LOCAL_MACHINE,

That LONG should not be there, as it was already defined above. Otherwise it looks fine to me.
(Assignee)

Comment 3

11 years ago
Created attachment 235656 [details] [diff] [review]
Remove excess long declaration.

Removed the Long... that's what I get for copy/paste.
I guess Mike still has to do the reviews?
Assignee: mozilla → abwillis1
Attachment #234705 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #235656 - Flags: review?(mozilla)

Comment 4

11 years ago
Comment on attachment 235656 [details] [diff] [review]
Remove excess long declaration.

r=mkaply
Attachment #235656 - Flags: review?(mozilla) → review+

Comment 5

11 years ago
Patch checked into trunk (with a small whitespace change to have the RegOpenKeyEx() arguments aligned).
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Comment 6

11 years ago
Reminder to myself: get this into branch...

Comment 7

11 years ago
(In reply to comment #6)
> Reminder to myself: get this into branch...

Somehow bugmail of this bug never arrives in my mailbox. But now, finally, I checked this into the 1.8 branch.
Keywords: fixed1.8.1.2

Comment 8

10 years ago
Verifying some older bugs.

(In this case verified that the fix is in but it wasn't necessarily complete, see bug 369695.)
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.2 → verified1.8.1.2
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.