Closed Bug 349439 Opened 17 years ago Closed 17 years ago

update MOZILLA_USE_EXTENDED_FT2LIB

Categories

(Core Graveyard :: GFX: OS/2, defect)

Product:
Core Graveyard
Component:
GFX: OS/2
Platform:
Other
OS/2
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: abwillis1, Assigned: abwillis1)

Details

(Keywords: verified1.8.1.2)

Attachments

(1 file, 1 obsolete file)

Remove excess long declaration.
3.30 KB, patch
mkaply
: review+
Details | Diff | Splinter Review 
The latest release of Innowin Font Engine now will use HKLM so there may not be a HKCU field or even if there is SM/FF/ETC may not be in it but in HKLM instead.  
Patch to follow that should take care of either case.
Attached patch Add HKLM check (obsolete) — — Splinter Review 

    
    

    
  
Comment on attachment 234705 [details] [diff] [review]
Add HKLM check

>     // Is FT2LIB enabled?
>     HKEY key;
>     LONG result = RegOpenKeyEx(HKEY_CURRENT_USER,
>                                "Software\\Innotek\\InnoTek Font Engine", 0,
>                                KEY_READ, &key);
>     if (result != ERROR_SUCCESS) {
>-      DosFreeModule(hmod);
>-      return PR_FALSE;
>+      LONG result = RegOpenKeyEx(HKEY_LOCAL_MACHINE,

That LONG should not be there, as it was already defined above. Otherwise it looks fine to me.

    
    

    
  


  
Removed the Long... that's what I get for copy/paste.
I guess Mike still has to do the reviews?
Assignee: mozilla → abwillis1

        Attachment #234705 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

        Attachment #235656 -
        Flags: review?(mozilla)

    
    

    
  
Comment on attachment 235656 [details] [diff] [review]
Remove excess long declaration.

r=mkaply

        Attachment #235656 -
        Flags: review?(mozilla) → review+

    
    

    
  
Patch checked into trunk (with a small whitespace change to have the RegOpenKeyEx() arguments aligned).
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
    

    
  
Reminder to myself: get this into branch...

    
    

    
  
(In reply to comment #6)
> Reminder to myself: get this into branch...

Somehow bugmail of this bug never arrives in my mailbox. But now, finally, I checked this into the 1.8 branch.
Keywords: fixed1.8.1.2

    
    

    
  
Verifying some older bugs.

(In this case verified that the fix is in but it wasn't necessarily complete, see bug 369695.)
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.2 → verified1.8.1.2
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.