Closed Bug 349619 Opened 19 years ago Closed 19 years ago

Assertion [@ BindNameToSlot] with let block, object literal getter/setter

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla1.8.1

People

(Reporter: jruderman, Assigned: brendan)

References

Details

(Keywords: crash, testcase, verified1.8.1)

Crash Data

Attachments

(1 file)

javascript:function() { let(y=3) { ({ get y() { }, set y(z) { } }) } } Assertion failure: 0, at /Users/admin/trunk/mozilla/js/src/jsemit.c:1891
Attached patch fixSplinter Review
Assignee: general → brendan
Status: NEW → ASSIGNED
Attachment #235179 - Flags: review?(shaver)
OS: Mac OS X 10.4 → All
Priority: -- → P1
Hardware: Macintosh → All
Target Milestone: --- → mozilla1.8.1
Comment on attachment 235179 [details] [diff] [review] fix r=shaver
Attachment #235179 - Flags: review?(shaver) → review+
Checking in jsemit.c; /cvsroot/mozilla/js/src/jsemit.c,v <-- jsemit.c new revision: 3.186; previous revision: 3.185 done Checking in jsparse.c; /cvsroot/mozilla/js/src/jsparse.c,v <-- jsparse.c new revision: 3.209; previous revision: 3.208 done Fixed on trunk. /be
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Flags: blocking1.8.1?
Resolution: --- → FIXED
Blocks: js1.7let
Attachment #235179 - Flags: approval1.8.1?
Comment on attachment 235179 [details] [diff] [review] fix a=beltzner on behalf of the 181drivers
Attachment #235179 - Flags: approval1.8.1? → approval1.8.1+
Flags: blocking1.8.1? → blocking1.8.1+
Fixed on the 1.8 branch. /be
Keywords: fixed1.8.1
Checking in regress-349619.js; /cvsroot/mozilla/js/tests/js1_7/block/regress-349619.js,v <-- regress-349619.js initial revision: 1.1
Flags: in-testsuite+
verified fixed 1.8 20060827 windows/mac*/linux. 1.9 test run is still running..., I'll verify it later tonight.
verified fixed 1.9 20060827 windows/mac*/linux
Status: RESOLVED → VERIFIED
Crash Signature: [@ BindNameToSlot]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: