Closed
Bug 349663
Opened 18 years ago
Closed 18 years ago
Function with const and *= changes during uneval-eval round trip
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.8.1
People
(Reporter: jruderman, Assigned: brendan)
References
Details
(Keywords: testcase, verified1.8.1)
Attachments
(1 file)
1.96 KB,
patch
|
shaver
:
review+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
> function() { const h; for(null; h *= ""; null) ; } function () { const h; for (null; h * ""; null) { } } > function () { const h; for (null; h * ""; null) { } } function () { const h; for (null; h * 0; null) { } } It would be nice if the "" became 0 the first time. My fuzzer in bug 349611 depends on functions not changing during round-trips in order to find "real" bugs in the decompiler.
Assignee | ||
Comment 1•18 years ago
|
||
Easy patch to fold constants more thoroughly: the operands of assignment operators such as *=, and all operands of a chained expression of same precedence and left associativity (represented as a list to avoid binary tree space cost and recursive depth hazard). /be
Comment on attachment 235190 [details] [diff] [review] fix r=shaver
Attachment #235190 -
Flags: review?(shaver) → review+
Assignee | ||
Comment 3•18 years ago
|
||
Fixed on trunk. Checking in jsparse.c; /cvsroot/mozilla/js/src/jsparse.c,v <-- jsparse.c new revision: 3.210; previous revision: 3.209 done /be
Blocks: js1.7
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Flags: blocking1.8.1?
Resolution: --- → FIXED
Assignee | ||
Updated•18 years ago
|
Attachment #235190 -
Flags: approval1.8.1?
Comment 4•18 years ago
|
||
Comment on attachment 235190 [details] [diff] [review] fix a=beltzner on behalf of the 181drivers
Attachment #235190 -
Flags: approval1.8.1? → approval1.8.1+
Updated•18 years ago
|
Flags: blocking1.8.1? → blocking1.8.1+
Target Milestone: --- → mozilla1.8.1
Comment 6•18 years ago
|
||
Checking in regress-349663.js; /cvsroot/mozilla/js/tests/js1_5/Regress/regress-349663.js,v <-- regress-349663.js initial revision: 1.1
Flags: in-testsuite+
Comment 7•18 years ago
|
||
verified fixed 1.8 20060827 windows/mac*/linux note 1.8 passes with expected: function () { const h; for (null; h * 0; null) { } } actual: function () { const h; for (null; h * 0; null) { } } 1.8.0.7 passes with expected: function () { const h; for (null; ""; null) { } } actual: function () { const h; for (null; ""; null) { } }
Keywords: fixed1.8.1 → verified1.8.1
OS: Mac OS X 10.4 → All
You need to log in
before you can comment on or make changes to this bug.
Description
•