349743 - Lightning does not display real BUILD_ID to user

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stefan Sitter [:ssitter]]

At the moment Lightning does not show the real BUILD_ID to the user. Instead it displays a time calculated during build process.

For example todays win32 nightly has the build id "-DBUILD_ID=2006082206" according to the log files and can be downloaded from [http://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/2006-08-22-06-mozilla1.8/]. 

But Lightning displays 2006082207 to the user.

To be consistent and to avoid problems (e.g. with Litmus tool) we should display the correct BUILD_ID.

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: use BUILD_ID instead

Comment 2

[Matthew (lilmatt) Willis]

Comment on attachment 234964 [details] [diff] [review]
use BUILD_ID instead

@BUILD_ID@ will be undefined unless you assign it in Lightning's Makefile.in

Search for other uses of MOZ_BUILD_DATE inside the lightning directory, and if there are no more left, pull that definition as well.

Minusing based on missing changes to /m/c/lightning/Makefile.in

Comment 3

[Stefan Sitter [:ssitter]]

(In reply to comment #2)
> (From update of attachment 234964 [details] [diff] [review] [edit])
> @BUILD_ID@ will be undefined unless you assign it in Lightning's Makefile.in
> Minusing based on missing changes to /m/c/lightning/Makefile.in

The patch contains:

--- mozilla/calendar/lightning/Makefile.in 19 Jul 2006 20:39:45 .15
+++ mozilla/calendar/lightning/Makefile.in 22 Aug 2006 20:34:12 
@@ -66,15 +66,14 @@ THEME=winstripe
-MOZ_BUILD_DATE = $(shell $(PERL) -I$(topsrcdir)/config $(topsrcdir)/config/bdate.pl)
-DEFINES += -DMOZ_BUILD_DATE=$(MOZ_BUILD_DATE)
+DEFINES += -DBUILD_ID=$(BUILD_ID)

Is that not enough?

Comment 4

[Matthew (lilmatt) Willis]

Comment on attachment 234964 [details] [diff] [review]
use BUILD_ID instead

Man, I am such a moron.

Somehow I didn't see that part.

My apologies.

r1=lilmatt

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 234964 [details] [diff] [review]
use BUILD_ID instead

r=dmose; sorry for the delay reviewing.

Comment 6

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 7

[Stefan Sitter [:ssitter]]

VERIFIED with Thunderbird/1.5.0.5 (20060719) and Lightning/0.1+ (2006090112)