Closed
Bug 349790
Opened 18 years ago
Closed 18 years ago
Filepicker crashes.
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jst, Assigned: jst)
References
Details
(Keywords: fixed1.8.0.9, fixed1.8.1)
Attachments
(1 file)
|
1.72 KB,
patch
|
roc
:
review+
roc
:
superreview+
jay
:
approval1.8.0.9+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
Since bug 341218 was fixed I've been seeing a reliable crash in the file picker on Fedora Core 4. I dug into it, and found the problem in the code and came up with a fix. The problem is that nsFilePicker::LoadSymbolsGTK24() marks itself initialized even if the initialization fails, and leaves function pointers set to null that are later on expected to be callable. Patch coming up.
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #235022 -
Flags: superreview?(roc)
Attachment #235022 -
Flags: review?(roc)
Attachment #235022 -
Flags: superreview?(roc)
Attachment #235022 -
Flags: superreview+
Attachment #235022 -
Flags: review?(roc)
Attachment #235022 -
Flags: review+
|
|
Assignee | |
Comment 2•18 years ago
|
||
Fix landed on the trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 3•18 years ago
|
||
Comment on attachment 235022 [details] [diff] [review] Properly deal with gtk_file_chooser_set_do_overwrite_confirmation not existing. nominating together with fix for bug 341218
Attachment #235022 -
Flags: approval1.8.1?
|
||
Comment 4•18 years ago
|
||
Comment on attachment 235022 [details] [diff] [review] Properly deal with gtk_file_chooser_set_do_overwrite_confirmation not existing. a=schrep for drivers
Attachment #235022 -
Flags: approval1.8.1? → approval1.8.1+
Checked into 1.8.1 branch
Keywords: fixed1.8.1
|
||
Comment 6•18 years ago
|
||
Comment on attachment 235022 [details] [diff] [review] Properly deal with gtk_file_chooser_set_do_overwrite_confirmation not existing. Distros should get this patch along with 341218
Attachment #235022 -
Flags: approval1.8.0.10?
|
|
||
Comment 7•18 years ago
|
||
Comment on attachment 235022 [details] [diff] [review] Properly deal with gtk_file_chooser_set_do_overwrite_confirmation not existing. Distros should get this patch along with 341218
Attachment #235022 -
Flags: approval1.8.0.9?
|
||
Updated•18 years ago
|
Attachment #235022 -
Flags: approval1.8.0.10?
|
||
Comment 8•18 years ago
|
||
Comment on attachment 235022 [details] [diff] [review] Properly deal with gtk_file_chooser_set_do_overwrite_confirmation not existing. Approved for 1.8.0 branch, a=jay for drivers.
Attachment #235022 -
Flags: approval1.8.0.9? → approval1.8.0.9+
|
|
||
Updated•18 years ago
|
Assignee: nobody → jst
Checked into 1.8.0 branch
Keywords: fixed1.8.0.9
You need to log in
before you can comment on or make changes to this bug.
Description
•