Closed
Bug 349815
Opened 18 years ago
Closed 18 years ago
Decompilation of parameterized E4X xml-list literal in includes extra parens
Categories
(Core :: JavaScript Engine, defect, P3)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla1.8.1
People
(Reporter: jruderman, Assigned: mrbkap)
Details
(Keywords: testcase, verified1.8.1)
Attachments
(1 file)
976 bytes,
patch
|
brendan
:
review+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
> function (tag) { return <><{tag}></{tag}></>; }
function (tag) { return <>(<{tag}></{tag}>)</>; }
That changes the meaning of the function so that the returned E4X object contains a "(" before the empty element and a ")" after it.
Assignee | ||
Comment 1•18 years ago
|
||
Easy to fix.
Assignee | ||
Updated•18 years ago
|
OS: Mac OS X 10.4 → All
Priority: -- → P3
Hardware: Macintosh → All
Target Milestone: --- → mozilla1.8.1
Comment 2•18 years ago
|
||
Comment on attachment 235108 [details] [diff] [review] Fix Cool. Presumably we need high precedence to avoid parens when this feeds into a larger expression. In some future data-driven decompiler, we will have a separate flag for "turn off parens" on input, without harming output precedence. /be
Attachment #235108 -
Flags: review?(brendan)
Attachment #235108 -
Flags: review+
Attachment #235108 -
Flags: approval1.8.1?
Assignee | ||
Comment 3•18 years ago
|
||
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 4•18 years ago
|
||
Checking in regress-349815.js; /cvsroot/mozilla/js/tests/e4x/Regress/regress-349815.js,v <-- regress-349815.js initial revision: 1.1
Flags: in-testsuite+
Comment 5•18 years ago
|
||
Comment on attachment 235108 [details] [diff] [review] Fix a=beltzner on behalf of drivers for the MOZILLA_1_8_BRANCH
Attachment #235108 -
Flags: approval1.8.1? → approval1.8.1+
Comment 7•18 years ago
|
||
verified fixed 1.8 20060827 windows/mac*/linux
Keywords: fixed1.8.1 → verified1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•