Closed Bug 349815 Opened 18 years ago Closed 18 years ago

Decompilation of parameterized E4X xml-list literal in includes extra parens

Categories

(Core :: JavaScript Engine, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla1.8.1

People

(Reporter: jruderman, Assigned: mrbkap)

Details

(Keywords: testcase, verified1.8.1)

Attachments

(1 file)

> function (tag) { return <><{tag}></{tag}></>; }
function (tag) { return <>(<{tag}></{tag}>)</>; }

That changes the meaning of the function so that the returned E4X object contains a "(" before the empty element and a ")" after it.
Attached patch FixSplinter Review
Easy to fix.
Assignee: general → mrbkap
Status: NEW → ASSIGNED
Attachment #235108 - Flags: review?(brendan)
OS: Mac OS X 10.4 → All
Priority: -- → P3
Hardware: Macintosh → All
Target Milestone: --- → mozilla1.8.1
Comment on attachment 235108 [details] [diff] [review]
Fix

Cool.  Presumably we need high precedence to avoid parens when this feeds into a larger expression.  In some future data-driven decompiler, we will have a separate flag for "turn off parens" on input, without harming output precedence.

/be
Attachment #235108 - Flags: review?(brendan)
Attachment #235108 - Flags: review+
Attachment #235108 - Flags: approval1.8.1?
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Checking in regress-349815.js;
/cvsroot/mozilla/js/tests/e4x/Regress/regress-349815.js,v  <--  regress-349815.js
initial revision: 1.1
Flags: in-testsuite+
Comment on attachment 235108 [details] [diff] [review]
Fix

a=beltzner on behalf of drivers for the MOZILLA_1_8_BRANCH
Attachment #235108 - Flags: approval1.8.1? → approval1.8.1+
Fixed on the 1.8 branch.

/be
Keywords: fixed1.8.1
verified fixed 1.8 20060827 windows/mac*/linux
verified fixed 1.9 20060827 windows/mac*/linux
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: