Closed
Bug 349822
Opened 18 years ago
Closed 18 years ago
Incorrect decompilation for "x.@[2]"
Categories
(Core :: JavaScript Engine, defect, P2)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla1.8.1
People
(Reporter: jruderman, Assigned: brendan)
Details
(Keywords: testcase, verified1.8.1, Whiteboard: [baking until 8/24])
Attachments
(1 file)
|
2.80 KB,
patch
|
mrbkap
:
review+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
> function () { return x.@[2]; }
function () { return x.@(2); }
> function () { return x.@(2); }
SyntaxError on line 1: syntax error
|
Assignee | |
Comment 1•18 years ago
|
||
A little lookahead when decompiling QNAMEPART handles the common @foo (QNAMEPART flowing directly into TOATTRNAME), and TOATTRNAME handles the general computed attribute name case.
/be
|
|
Assignee | |
Updated•18 years ago
|
OS: Mac OS X 10.4 → All
Priority: -- → P2
Hardware: Macintosh → All
Target Milestone: --- → mozilla1.8.1
|
||
Comment 2•18 years ago
|
||
Comment on attachment 235046 [details] [diff] [review]
fix
I <3 the decompiler!
Attachment #235046 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Fixed on trunk.
/be
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Flags: blocking1.8.1?
Resolution: --- → FIXED
|
|
Assignee | |
Updated•18 years ago
|
Attachment #235046 -
Flags: approval1.8.1?
|
||
Updated•18 years ago
|
Flags: blocking1.8.1? → blocking1.8.1+
|
|
||
Updated•18 years ago
|
Whiteboard: [baking[
|
|
||
Updated•18 years ago
|
Whiteboard: [baking[ → [baking until 8/24]
|
||
Comment 4•18 years ago
|
||
Checking in regress-349822.js;
/cvsroot/mozilla/js/tests/e4x/Regress/regress-349822.js,v <-- regress-349822.js
initial revision: 1.1
Flags: in-testsuite+
|
|
||
Comment 5•18 years ago
|
||
oops.
Checking in e4x/Regress/regress-349822.js;
/cvsroot/mozilla/js/tests/e4x/Regress/regress-349822.js,v <-- regress-349822.js
new revision: 1.2; previous revision: 1.1
|
||
Comment 6•18 years ago
|
||
Comment on attachment 235046 [details] [diff] [review]
fix
a=beltzner on behalf of drivers for the MOZILLA_1_8_BRANCH
Attachment #235046 -
Flags: approval1.8.1? → approval1.8.1+
(In reply to comment #7)
> Fixed on the 1.8 branch.
This broke the 1.8 branch.
|
|
Assignee | |
Comment 9•18 years ago
|
||
(In reply to comment #8)
> (In reply to comment #7)
> > Fixed on the 1.8 branch.
>
> This broke the 1.8 branch.
My checkin message:
Argh, need to land more trunk patches to avoid merge hell.
Sorry about that -- no more blind merging for me.
/be
|
|
||
Comment 11•18 years ago
|
||
verified fixed 1.8 20060827 windows/mac*/linux
Keywords: fixed1.8.1 → verified1.8.1
|
|
||
Comment 12•18 years ago
|
||
update to match changing decompilation of x.@[2]
Checking in regress-349822.js;
/cvsroot/mozilla/js/tests/e4x/Regress/regress-349822.js,v <-- regress-349822.js
new revision: 1.3; previous revision: 1.2
done
You need to log in
before you can comment on or make changes to this bug.
Description
•