349899 - --enable-xpctools still fails during XULrunner build

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060820 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060820 Minefield/3.0a1

after checkin for bug #347595 building XULrunner still failes, not due to linker but compiler issues

i686-pc-linux-gnu-g++ -o nsXPCToolsCompiler.o -c -fvisibility=hidden
-DOSTYPE=\"Linux2.6\" -DOSARCH=\"Linux\" -DBUILD_ID=0000000000 -DJSFILE
-DJS_THREADSAFE  -I../../../../../dist/include/xpcom
-I../../../../../dist/include/xpconnect -I../../../../../dist/include/js
-I../../../../../dist/include/string -I../../../../../dist/include  
-I../../../../../dist/include/xpctools -I../../../../../dist/include/nspr   
-I../../../../../dist/sdk/include    -fPIC 
-DGENTOO_NSPLUGINS_DIR=\"/usr/lib/nsplugins\"
-DGENTOO_NSBROWSER_PLUGINS_DIR=\"/usr/lib/nsbrowser/plugins\"  -fno-rtti
-fno-handle-exceptions
-Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth
-Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -march=athlon-xp
-pipe -Wno-return-type -w -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -O2 
-DGENTOO_NSPLUGINS_DIR=\"/usr/lib/nsplugins\"
-DGENTOO_NSBROWSER_PLUGINS_DIR=\"/usr/lib/nsbrowser/plugins\"  -DMOZILLA_CLIENT
-include ../../../../../mozilla-config.h -Wp,-MD,.deps/nsXPCToolsCompiler.pp
nsXPCToolsCompiler.cpp
../../../../../dist/include/xpconnect/nsIXPConnect.h:386: error:
'nsQueryInterface' does not name a type
../../../../../dist/include/xpconnect/nsIXPConnect.h:392: error:
'nsQueryInterfaceWithError' does not name a type
gmake[2]: *** [nsXPCToolsCompiler.o] Error 1

Reproducible: Always

Comment 1

[timeless]

bryner's fault. he added a dependency to nsIXPConnect.idl

Comment 2

[Benjamin Smedberg]

timeless fixed this with a checkin to nsIXPConnect.idl today.

Comment 3

[timeless]

mozilla/js/src/xpconnect/idl/nsIXPConnect.idl 	1.43