User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060501 Epiphany/2.14 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060501 Epiphany/2.14 Currently the Pango font backend depends on Gtk+ using the PangoXft backend. Which is wrong for Gtk+ 2.8. Attaching fix. Reproducible: Always
Comment on attachment 235103 [details] [diff] [review] Mentioned patch That code hasn't evolved much since blizzard's initial check-in. I will sr if jshin is happy with the patch. http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/gfx/src/gtk/mozilla-decoder.cpp&rev=HEAD&mark=1.3
Note to self. Undo the debugging #define #undef DEBUG_CUSTOM_ENCODER +#define DEBUG_CUSTOM_ENCODER 1
Created attachment 235350 [details] [diff] [review] Updated patch Removed the debugging statement.
Comment on attachment 235350 [details] [diff] [review] Updated patch r=jshin
Comment on attachment 235350 [details] [diff] [review] Updated patch sr=rbs, I will check this in quickly.
(In reply to comment #7) > Checked in. > In bug 338446 we took care that configure(.in) checks for the presence of pangoxft in order to pull it in, as pangoxft automatically pulled by gtk+ 2.8. The only reason was the dependency of gfx/src/gtk/mozilla-decoder.cpp on pangoxft. Now, we could reverse the part of the patch https://bugzilla.mozilla.org/attachment.cgi?id=227071 concerning configure.in (but not gfx/src/gtk/Makefile.in) as pangoxft isn't needed anymore in case using default-toolkit=gtk2. Interestingly, yesterday for the cairo-gtk2 toolkit a patch for bug 334064 was checked in that brings in more pangoxft dependencies.
Comment on attachment 235350 [details] [diff] [review] Updated patch Branch approval requested for same reasons as: https://bugzilla.mozilla.org/show_bug.cgi?id=349904#c6
Comment on attachment 235350 [details] [diff] [review] Updated patch approved for 184.108.40.206, a=dveditz for release-drivers
Checking in mozilla-decoder.cpp; /cvsroot/mozilla/gfx/src/gtk/Attic/mozilla-decoder.cpp,v <-- mozilla-decoder.c pp new revision: 220.127.116.11; previous revision: 1.3 done Checked into the 1.8.1 branch.