Closed
Bug 349912
Opened 19 years ago
Closed 19 years ago
shouldn't need to define XPCOM_GLUE to 1, instead of just defining it on branch
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8.1beta2
People
(Reporter: Biesinger, Assigned: Biesinger)
References
()
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
729 bytes,
patch
|
benjamin
:
review+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
the URL above should use #ifdef XPCOM_GLUE instead of just #if XPCOM_GLUE, so that a #define XPCOM_GLUE is sufficient.
| Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8.1beta2
Version: Trunk → 1.8 Branch
| Assignee | ||
Comment 1•19 years ago
|
||
this seems to be already fixed on trunk, so this is a branch-only patch
Attachment #235114 -
Flags: review?(benjamin)
Updated•19 years ago
|
Attachment #235114 -
Flags: review?(benjamin) → review+
| Assignee | ||
Comment 2•19 years ago
|
||
Comment on attachment 235114 [details] [diff] [review]
patch
zero risk patch to make things a bit simpler for embeddors
Attachment #235114 -
Flags: approval1.8.1?
| Assignee | ||
Updated•19 years ago
|
Summary: need to define XPCOM_GLUE to 1, instead of just defining it on branch → shouldn't need to define XPCOM_GLUE to 1, instead of just defining it on branch
Comment 3•19 years ago
|
||
Comment on attachment 235114 [details] [diff] [review]
patch
a=beltzner on behalf of drivers for the MOZILLA_1_8_BRANCH
Attachment #235114 -
Flags: approval1.8.1? → approval1.8.1+
| Assignee | ||
Comment 4•19 years ago
|
||
Checking in nscore.h;
/cvsroot/mozilla/xpcom/base/nscore.h,v <-- nscore.h
new revision: 1.85.2.3; previous revision: 1.85.2.2
done
You need to log in
before you can comment on or make changes to this bug.
Description
•