Closed
Bug 349925
Opened 18 years ago
Closed 18 years ago
SeaMonkey debug build fails on 1.8 branch
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: stefanh, Assigned: stefanh)
Details
(Keywords: fixed-seamonkey1.1a, fixed1.8.1)
Attachments
(1 file)
882 bytes,
patch
|
benjamin
:
review+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
My seamonkey ppc debug build fails in xpcom/ - using gcc3.3 on 10.3.9:
In file included from ../../dist/include/xpcom/nsILocalFile.h:10,
from /Users/Stefan/mozilla-1.8/mozilla/xpcom/tests/TestTArray.cpp:49:
../../dist/include/xpcom/nsISupportsUtils.h: In static member function `static
const nsIID& nsCOMTypeInfo<T>::GetIID() [with T = nsIFile]':
../../dist/include/xpcom/nsDirectoryServiceUtils.h:56: instantiated from here
../../dist/include/xpcom/nsISupportsUtils.h:202: error: incomplete type '
nsIFile' cannot be used to name a scope
make[4]: *** [TestTArray.o] Error 1
make[3]: *** [libs] Error 2
make[2]: *** [tier_2] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2
Configure options:
----------------------------------------------------------------
ac_add_options --with-macos-sdk=/Developer/SDKs/MacOSX10.2.8.sdk
ac_add_options --enable-application=suite
ac_add_options --enable-debug
ac_add_options --disable-optimize
ac_add_options --enable-extensions=default,tasks
ac_add_options --enable-svg
ac_add_options --enable-canvas
ac_add_options --enable-crypto
----------------------------------------------------------------
I haven't checked the trunk (been some issues with the tree recently), but binus on SeaMonkey-ports seems doing fine.
Assignee | ||
Comment 1•18 years ago
|
||
As biesi pointed out to me, this is caused by a missing '#include "nsIFile.h"' in nsDirectoryServiceUtils.h. So my local tree is happy now.
Assignee | ||
Comment 2•18 years ago
|
||
Attachment #235280 -
Flags: review?(benjamin)
Updated•18 years ago
|
Attachment #235280 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 3•18 years ago
|
||
Comment on attachment 235280 [details] [diff] [review]
One-liner, add missing include to nsDirectoryServiceUtils.h
This just adds a missing include to the branch version of the file in order to fix a debug build issue.
Attachment #235280 -
Flags: approval1.8.1?
Updated•18 years ago
|
Assignee: nobody → stefanh
Comment 4•18 years ago
|
||
Comment on attachment 235280 [details] [diff] [review]
One-liner, add missing include to nsDirectoryServiceUtils.h
a=beltzner on behalf of the 181drivers
Attachment #235280 -
Flags: approval1.8.1? → approval1.8.1+
Assignee | ||
Comment 5•18 years ago
|
||
Karsten,
can you check in the patch on 1.8, please?
Comment 6•18 years ago
|
||
Checked in on MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed-seamonkey1.1a,
fixed1.8.1
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•