Fix non-virtual destructor warnings

RESOLVED FIXED in Camino1.5

Status

RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: froodian, Assigned: alqahira)

Tracking

({fixed1.8.1})

1.8 Branch
Camino1.5
PowerPC
Mac OS X
fixed1.8.1

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

12 years ago
Raise your hand if you hate the non-virtual destructor warnings.  That's what I thought.  Most projects have turned these off long ago, and a=mento to get rid of the warnings.
Status: NEW → ASSIGNED
Assignee: nobody → alqahira
Status: ASSIGNED → NEW
Created attachment 235156 [details] [diff] [review]
Trunk project patch

I have no idea what the "garbage" changes at the bottom of the patch are, but I pulled a fresh project file and repeated and got the same.
Attachment #235156 - Flags: superreview?(mark)
Created attachment 235157 [details] [diff] [review]
branch patch

The branch patch is completely sane.
Attachment #235157 - Flags: superreview?(mark)
Comment on attachment 235156 [details] [diff] [review]
Trunk project patch

I wonder if that "garbage" is Xcode objecting to where mento placed those when doing manual surgery to fix the build after spellchecker joined libxul?

Comment 4

12 years ago
/me raises his hand...

r=me on both, FWIW.

cl

Comment 5

12 years ago
Comment on attachment 235156 [details] [diff] [review]
Trunk project patch

>-				GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
>+				GCC_WARN_NON_VIRTUAL_DESTRUCTOR = NO;
> 				GCC_WARN_UNINITIALIZED_AUTOS = YES;
> 				WARNING_CFLAGS = "-Wno-non-virtual-dtor";

We can get rid of this line now, right?

We also set WARNING_CFLAGS like this for the DeploymentSymbols style.  We should take that out and rely on GCC_WARN_NON_VIRTUAL_DESTRUCTOR = NO there too.

>-//7B0
>-//7B1
>-//7B2
>-//7B3
>-//7B4

Yup, these are just silly comment changes.  They don't affect anything and Xcode ignores them when it reads them, but if it wants to do this, we should let it.
Created attachment 235322 [details] [diff] [review]
trunk with extra warningectomy

I might just yet figure out how to use Xcode :P
Attachment #235156 - Attachment is obsolete: true
Attachment #235156 - Flags: superreview?(mark)
Created attachment 235323 [details] [diff] [review]
branch patch with extra warningectomy
Attachment #235157 - Attachment is obsolete: true
Attachment #235323 - Flags: superreview?(mark)
Attachment #235157 - Flags: superreview?(mark)

Comment 8

12 years ago
Comment on attachment 235322 [details] [diff] [review]
trunk with extra warningectomy

Okee dokee
Attachment #235322 - Flags: superreview?(mark) → superreview+

Comment 9

12 years ago
Comment on attachment 235323 [details] [diff] [review]
branch patch with extra warningectomy

This one too.  Thanks, Mr. Project!
Attachment #235323 - Flags: superreview?(mark) → superreview+
(Reporter)

Updated

12 years ago
Whiteboard: [needs checkin]

Comment 10

12 years ago
Yehaw!   Reminder note: you'll need to re-convert the old-style xcode project in your tree to a new project file, in order to get this fix.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
You need to log in before you can comment on or make changes to this bug.