349948 - Fix non-virtual destructor warnings

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[froodian (Ian Leue)]

Raise your hand if you hate the non-virtual destructor warnings.  That's what I thought.  Most projects have turned these off long ago, and a=mento to get rid of the warnings.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Trunk project patch

I have no idea what the "garbage" changes at the bottom of the patch are, but I pulled a fresh project file and repeated and got the same.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: branch patch

The branch patch is completely sane.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 235156 [details] [diff] [review]
Trunk project patch

I wonder if that "garbage" is Xcode objecting to where mento placed those when doing manual surgery to fix the build after spellchecker joined libxul?

Comment 4

[Chris Lawson (gone)]

/me raises his hand...

r=me on both, FWIW.

cl

Comment 5

[Mark Mentovai]

Comment on attachment 235156 [details] [diff] [review]
Trunk project patch

>-				GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
>+				GCC_WARN_NON_VIRTUAL_DESTRUCTOR = NO;
> 				GCC_WARN_UNINITIALIZED_AUTOS = YES;
> 				WARNING_CFLAGS = "-Wno-non-virtual-dtor";

We can get rid of this line now, right?

We also set WARNING_CFLAGS like this for the DeploymentSymbols style.  We should take that out and rely on GCC_WARN_NON_VIRTUAL_DESTRUCTOR = NO there too.

>-//7B0
>-//7B1
>-//7B2
>-//7B3
>-//7B4

Yup, these are just silly comment changes.  They don't affect anything and Xcode ignores them when it reads them, but if it wants to do this, we should let it.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: trunk with extra warningectomy

I might just yet figure out how to use Xcode :P

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: branch patch with extra warningectomy

Comment 8

[Mark Mentovai]

Comment on attachment 235322 [details] [diff] [review]
trunk with extra warningectomy

Okee dokee

Comment 9

[Mark Mentovai]

Comment on attachment 235323 [details] [diff] [review]
branch patch with extra warningectomy

This one too.  Thanks, Mr. Project!

Comment 10

[Håkan Waara]

Yehaw!   Reminder note: you'll need to re-convert the old-style xcode project in your tree to a new project file, in order to get this fix.