Closed Bug 349948 Opened 14 years ago Closed 14 years ago

Fix non-virtual destructor warnings

Categories

(Camino Graveyard :: General, defect)

1.8 Branch
PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Camino1.5

People

(Reporter: froodian, Assigned: alqahira)

Details

(Keywords: fixed1.8.1)

Attachments

(2 files, 2 obsolete files)

Raise your hand if you hate the non-virtual destructor warnings.  That's what I thought.  Most projects have turned these off long ago, and a=mento to get rid of the warnings.
Assignee: nobody → alqahira
Status: ASSIGNED → NEW
Attached patch Trunk project patch (obsolete) — Splinter Review
I have no idea what the "garbage" changes at the bottom of the patch are, but I pulled a fresh project file and repeated and got the same.
Attachment #235156 - Flags: superreview?(mark)
Attached patch branch patch (obsolete) — Splinter Review
The branch patch is completely sane.
Attachment #235157 - Flags: superreview?(mark)
Comment on attachment 235156 [details] [diff] [review]
Trunk project patch

I wonder if that "garbage" is Xcode objecting to where mento placed those when doing manual surgery to fix the build after spellchecker joined libxul?
/me raises his hand...

r=me on both, FWIW.

cl
Comment on attachment 235156 [details] [diff] [review]
Trunk project patch

>-				GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
>+				GCC_WARN_NON_VIRTUAL_DESTRUCTOR = NO;
> 				GCC_WARN_UNINITIALIZED_AUTOS = YES;
> 				WARNING_CFLAGS = "-Wno-non-virtual-dtor";

We can get rid of this line now, right?

We also set WARNING_CFLAGS like this for the DeploymentSymbols style.  We should take that out and rely on GCC_WARN_NON_VIRTUAL_DESTRUCTOR = NO there too.

>-//7B0
>-//7B1
>-//7B2
>-//7B3
>-//7B4

Yup, these are just silly comment changes.  They don't affect anything and Xcode ignores them when it reads them, but if it wants to do this, we should let it.
I might just yet figure out how to use Xcode :P
Attachment #235156 - Attachment is obsolete: true
Attachment #235156 - Flags: superreview?(mark)
Attachment #235157 - Attachment is obsolete: true
Attachment #235323 - Flags: superreview?(mark)
Attachment #235157 - Flags: superreview?(mark)
Comment on attachment 235322 [details] [diff] [review]
trunk with extra warningectomy

Okee dokee
Attachment #235322 - Flags: superreview?(mark) → superreview+
Comment on attachment 235323 [details] [diff] [review]
branch patch with extra warningectomy

This one too.  Thanks, Mr. Project!
Attachment #235323 - Flags: superreview?(mark) → superreview+
Whiteboard: [needs checkin]
Yehaw!   Reminder note: you'll need to re-convert the old-style xcode project in your tree to a new project file, in order to get this fix.
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
You need to log in before you can comment on or make changes to this bug.