Closed Bug 349996 Opened 16 years ago Closed 13 years ago

Categories: multiselection should be enabled to remove more than one category

Categories

(Calendar :: Preferences, enhancement)

Product:
Calendar
Component:
Preferences
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: damian.publicemail, Assigned: Fallen)

Details

Attachments

(1 file, 1 obsolete file)

Fix - v2
7.67 KB, patch
Taraman
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060823 Calendar/0.3a2+

Sunbird has many predefined category

in my opinion most people will not use all of them so it will be nice if they can delete them at once
for example I removed all of them and then add my own with specified colors: 5-7 no more

Reproducible: Always
Status: UNCONFIRMED → NEW
Component: Internal Components → Preferences
Ever confirmed: true
OS: Windows XP → All
QA Contact: base → preferences
Hardware: PC → All
Summary: categories: multiselection should be enabled to remove more than one category → Categories: multiselection should be enabled to remove more than one category
Same for Lightning.  Adding, deleting, importing and/or exporting categories and colors should be more flexible.
Attached patch Fix - v1 (obsolete) — — Splinter Review 
This patch takes care. I noticed the category handling is a real mess, we should clean up categories.js some time.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #429441 - Flags: review?(Mozilla)
Comment on attachment 429441 [details] [diff] [review]
Fix - v1

Patch looks good except one problem:

Edit button is disabled when mulitple categories are selceted.
But this does not apply to the dblclick handler for the Listbox.

When you have multiple items selected and then ctrl-dblclick an entry in the listbox, the first selected item of the multi-selction is opened for editing.

Therefore r- for now.
Attachment #429441 - Flags: review?(Mozilla) → review-
Attached patch Fix - v2 — — Splinter Review 
Thanks for catching that, this fixes.
Attachment #429441 - Attachment is obsolete: true
Attachment #430920 - Flags: review?(Mozilla)
Comment on attachment 430920 [details] [diff] [review]
Fix - v2

Works as expected.

r=markus
Attachment #430920 - Flags: review?(Mozilla) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/4d25f670a616>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0b2
You need to log in before you can comment on or make changes to this bug.