349996 - Categories: multiselection should be enabled to remove more than one category

Status: RESOLVED FIXED

(Calendar :: Preferences, enhancement)

Description

[Damian Szczepanik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060823 Calendar/0.3a2+

Sunbird has many predefined category

in my opinion most people will not use all of them so it will be nice if they can delete them at once
for example I removed all of them and then add my own with specified colors: 5-7 no more

Reproducible: Always

Comment 1

[d2_c2]

Same for Lightning.  Adding, deleting, importing and/or exporting categories and colors should be more flexible.  

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

This patch takes care. I noticed the category handling is a real mess, we should clean up categories.js some time.

Comment 3

[Markus Adrario [:Taraman]]

Comment on attachment 429441 [details] [diff] [review]
Fix - v1

Patch looks good except one problem:

Edit button is disabled when mulitple categories are selceted.
But this does not apply to the dblclick handler for the Listbox.

When you have multiple items selected and then ctrl-dblclick an entry in the listbox, the first selected item of the multi-selction is opened for editing.

Therefore r- for now.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v2

Thanks for catching that, this fixes.

Comment 5

[Markus Adrario [:Taraman]]

Comment on attachment 430920 [details] [diff] [review]
Fix - v2

Works as expected.

r=markus

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/4d25f670a616>

-> FIXED