Closed Bug 350211 Opened 18 years ago Closed 18 years ago

Allow build-system addons part 2 & 3 - $(MOZ_BUILD_APP)/build.mk

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(2 files, 1 obsolete file)

Spinoff from bug 325096, allowing build-system addons... control the main build loop (tiers and whatnot) from app-specific places, to make life easier on everyone.
Attached patch Modularize builds, rev. 1 (obsolete) — Splinter Review
This moves the main build driver to app-specific build directories. I'm still building some configurations (camino and tbird), but it appears to work.
Attachment #235482 - Flags: review?(mark)
Woot, this works.
Attachment #235482 - Attachment is obsolete: true
Attachment #235693 - Flags: review?(mark)
Attachment #235482 - Flags: review?(mark)
Comment on attachment 235693 [details] [diff] [review]
Modularize builds, rev. 1.1

This is pretty cool.
Attachment #235693 - Flags: review?(mark) → review+
Attachment #236019 - Flags: superreview?(mark)
Attachment #236019 - Flags: superreview?
Attachment #236019 - Flags: review?(benjamin)
Attachment #236019 - Flags: review?
Comment on attachment 236019 [details] [diff] [review]
Bustage fix, missed nspr/build.mk Makefile.in

I don't understand... these files already landed, what is this patch about?
FIXED on trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Attachment #236019 - Flags: superreview?(mark)
Attachment #236019 - Flags: review?(benjamin)
Comment on attachment 235693 [details] [diff] [review]
Modularize builds, rev. 1.1

Index: calendar/build.mk
+tier_app_dirs += \
...
+	calendar\sunbird \

shouldn't that be a forward slash? :)
Blocks: 351377
This has caused bug 351377, because the commit for 350211 removed js/Makefile.in, but didn't update allmakefiles.sh
Depends on: 352173
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: