Closed Bug 350271 Opened 18 years ago Closed 18 years ago

"if(0x10.(a))" decomplies incorrectly

Categories

(Core :: JavaScript Engine, defect, P2)

defect

Tracking

()

VERIFIED FIXED
mozilla1.8.1

People

(Reporter: jruderman, Assigned: brendan)

Details

(Keywords: testcase, verified1.8.1, Whiteboard: [baking until 8/29])

Attachments

(1 file)

> function () { if(0x10.(a)) { h(); } }
function () { if (16.(a)) { h(); } }

> function () { if (16.(a)) { h(); } 
function () { if (16(a)) { h(); } }

Note that the . in the initial code appears to be the "XML filtering predicate operator" from E4X rather than property access.

The .. operator does not seem to suffer from this problem.
Attached patch fixSplinter Review
The data-driven decompiler is taking shape in my head: input precedence, output precedence, template for stack output based on arity, special quoting features...

/be
Assignee: general → brendan
Status: NEW → ASSIGNED
Attachment #235540 - Flags: superreview?(shaver)
Attachment #235540 - Flags: review?(mrbkap)
OS: Mac OS X 10.4 → All
Priority: -- → P2
Hardware: Macintosh → All
Target Milestone: --- → mozilla1.8.1
Attachment #235540 - Flags: review?(mrbkap) → review+
Attachment #235540 - Flags: approval1.8.1?
Fixed on trunk.

/be
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment on attachment 235540 [details] [diff] [review]
fix

sr=shaver
Attachment #235540 - Flags: superreview?(shaver) → superreview+
Whiteboard: [baking until 8/29]
Comment on attachment 235540 [details] [diff] [review]
fix

a=schrep/beltnzer for drivers.
Attachment #235540 - Flags: approval1.8.1? → approval1.8.1+
Fixed on the 1.8 branch.

/be
Keywords: fixed1.8.1
Checking in regress-350271.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-350271.js,v  <--  regress-350271.js
initial revision: 1.1
Flags: in-testsuite+
verified fixed 1.8 20060828 windows/mac*/linux
verified fixed 1.9 20060830 windows/mac*/linux
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: