Closed
Bug 350333
Opened 19 years ago
Closed 19 years ago
Editable trees: pressing Home/End keys in textbox shouldn't go out of the edit mode
Categories
(Core :: XUL, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: asqueella, Assigned: enndeakin)
References
Details
(Keywords: regression, testcase)
Attachments
(1 file, 1 obsolete file)
|
23.09 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
STR:
1. Open attachment 235591 [details] in the browser (can't test in chrome due to bug 350332)
2. Double click the first cell
3. Press the Home key to move cursor to the beginning of the text
Actual results:
The textbox disappears
Expected results:
The textbox stays; cursor is moved to the beginning of the textbox.
|
Reporter | |
Comment 1•19 years ago
|
||
same for the End key.
Keywords: testcase
Summary: Editable trees: pressing Home key in textbox shouldn't go out of the edit mode → Editable trees: pressing Home/End keys in textbox shouldn't go out of the edit mode
|
|
Reporter | |
Comment 2•19 years ago
|
||
A number of keypress handlers were missing the check to see if the tree is being edited right ATM. I added the check to all of them (including, for example, vk_down). I'm quite sure it is appropriate on Windows, but I'm not sure about other platforms.
Assignee: Jan.Varga → asqueella
Status: NEW → ASSIGNED
Attachment #235603 -
Flags: review?(enndeakin)
|
|
Reporter | |
Comment 3•19 years ago
|
||
I'll make an XPFE patch before checkin if/after this gets r+'s.
|
Assignee | |
Comment 4•19 years ago
|
||
This isn't the right patch. In fact, the changes in this patch were there originally but removed and target="phase" was added to prevent the handlers from being called. This is a regression.
Keywords: regression
|
|
Reporter | |
Comment 5•19 years ago
|
||
Comment on attachment 235603 [details] [diff] [review]
patch
Yes, I understand now.
Attachment #235603 -
Attachment is obsolete: true
Attachment #235603 -
Flags: review?(enndeakin)
|
|
Reporter | |
Updated•19 years ago
|
Assignee: asqueella → Jan.Varga
Status: ASSIGNED → NEW
|
|
Assignee | |
Comment 6•19 years ago
|
||
OK, I think Nickolay's patch may be OK after all. Maybe I was imagining that everything was working before. This patch fixes the event handling for this bug and bugs 350032 and 350035.
|
||
Comment 7•19 years ago
|
||
Comment on attachment 239065 [details] [diff] [review]
fix up event handling in trees
Looks like smaug "broke" this in bug 339659.
Attachment #239065 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 8•19 years ago
|
||
I knew I wasn't crazy. At least, not because of this.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: xptoolkit.trees → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•