Closed Bug 350348 Opened 14 years ago Closed 14 years ago

Hard coded strings in print output (in calHtmlExport.js)

Categories

(Calendar :: Printing, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: ssitter)

References

()

Details

(Keywords: l12y)

Attachments

(1 file)

(I thought there was already a bug files but I can't find it right now.)

Printing in list respectivly export to html uses hard coded strings 'Title', 'When', 'Location' and 'Description'. That should be localizable.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060826 Calendar/0.3a2+.
Flags: blocking0.3+
Attached patch patchSplinter Review
Patch adds new strings for html output to calendar.properties. 
Also replaces document title 'null' with a default string.
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #235637 - Flags: second-review?(jminta)
Attachment #235637 - Flags: first-review?(mattwillis)
Comment on attachment 235637 [details] [diff] [review]
patch

r1=lilmatt

Nice catch.
Attachment #235637 - Flags: first-review?(mattwillis) → first-review+
Whiteboard: [patch in hand][waiting on jminta review]
Comment on attachment 235637 [details] [diff] [review]
patch

Moving r2 to dmose to ensure that this gets in before String Freeze.
Attachment #235637 - Flags: second-review?(jminta) → second-review?(dmose)
Comment on attachment 235637 [details] [diff] [review]
patch

Looks good; r=dmose.
Attachment #235637 - Flags: second-review?(dmose) → second-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [patch in hand][waiting on jminta review]
Verified with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060907 Calendar/0.3a2+ and language pack nl and fr.
Status: RESOLVED → VERIFIED
Hardware: PC → All
You need to log in before you can comment on or make changes to this bug.