Closed Bug 350384 Opened 14 years ago Closed 14 years ago

invalid 'in' operand window.opener.InlineSpellChecker closing spellcheck in Composer

Categories

(Core :: Spelling checker, defect)

1.8 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.8.1

People

(Reporter: ajschult784, Assigned: iann_bugzilla)

References

Details

(Keywords: fixed-seamonkey1.1b, fixed1.8.1, regression)

Attachments

(1 file)

With linux seamonkey build 2006-08-27-08-trunk, if I invoke spellcheck in Composer (not mail compose) and then close it, I get

Error: invalid 'in' operand window.opener.InlineSpellChecker
Source File: chrome://editor/content/EdSpellCheck.js
Line: 576

It's doing
  if ("inlineSpellChecker" in window.opener.InlineSpellChecker)

but there is no window.opener.InlineSpellChecker.  This is bustage from bug 337155.
hmm, not really spell check...
Blocks: 337155
Component: Spelling checker → Composer
Product: Core → Mozilla Application Suite
QA Contact: spelling-checker → composer
Oh, and the user-visible symptom here is that the first click on the close button doesn't do anything.
Flags: blocking-seamonkey1.1b?
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: PC → All
This patch:
* Adds a check for an InlineSpellChecker before trying to use it.
Attachment #235690 - Flags: review?(neil)
Comment on attachment 235690 [details] [diff] [review]
Test for an InlineSpellChecker first patch v0.1 (Checked into trunk & 1.8.1 branch)

TB doesn't have web page composer ;-)
Attachment #235690 - Flags: review?(neil) → review+
Attachment #235690 - Flags: superreview?(bienvenu)
Attachment #235690 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 235690 [details] [diff] [review]
Test for an InlineSpellChecker first patch v0.1 (Checked into trunk & 1.8.1 branch)

Checking in (trunk)
editor/ui/dialogs/content/EdSpellCheck.js;
new revision: 1.61; previous revision: 1.60
mail/components/compose/content/EdSpellCheck.js;
new revision: 1.7; previous revision: 1.6
done
Attachment #235690 - Attachment description: Test for an InlineSpellChecker first patch v0.1 → Test for an InlineSpellChecker first patch v0.1 (Checked into trunk)
Comment on attachment 235690 [details] [diff] [review]
Test for an InlineSpellChecker first patch v0.1 (Checked into trunk & 1.8.1 branch)

Requesting approval for SM1.1b
Attachment #235690 - Flags: approval-seamonkey1.1b?
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Attachment #235690 - Flags: approval-seamonkey1.1b? → approval-seamonkey1.1b+
Component: Composer → Spelling checker
Flags: blocking-seamonkey1.1b?
Flags: approval-seamonkey1.1b+
Product: Mozilla Application Suite → Core
Target Milestone: --- → mozilla1.8.1
Version: Trunk → 1.8 Branch
Comment on attachment 235690 [details] [diff] [review]
Test for an InlineSpellChecker first patch v0.1 (Checked into trunk & 1.8.1 branch)

Requesting a-1.8.1 for simple regression fix
Attachment #235690 - Flags: approval1.8.1?
Comment on attachment 235690 [details] [diff] [review]
Test for an InlineSpellChecker first patch v0.1 (Checked into trunk & 1.8.1 branch)

a=beltzner on behalf of the 181drivers
Attachment #235690 - Flags: approval1.8.1? → approval1.8.1+
Comment on attachment 235690 [details] [diff] [review]
Test for an InlineSpellChecker first patch v0.1 (Checked into trunk & 1.8.1 branch)

Checking in (1.8.1 branch)
editor/ui/dialogs/content/EdSpellCheck.js;
new revision: 1.57.28.4; previous revision: 1.57.28.3
mail/components/compose/content/EdSpellCheck.js;
new revision: 1.4.4.3; previous revision: 1.4.4.2
done
Attachment #235690 - Attachment description: Test for an InlineSpellChecker first patch v0.1 (Checked into trunk) → Test for an InlineSpellChecker first patch v0.1 (Checked into trunk & 1.8.1 branch)
You need to log in before you can comment on or make changes to this bug.