Closed Bug 350550 Opened 17 years ago Closed 17 years ago

LiveConnect shouldn't export NSGetFactory

Categories

(Core Graveyard :: Java: Live Connect, defect)

Product:
Core Graveyard
Component:
Java: Live Connect
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bent.mozilla, Assigned: benjamin)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

Remove unused exports, rev. 1
3.44 KB, patch
brendan
: review+
jhpedemonte
: review+
beltzner
: approval1.8.1+
Details | Diff | Splinter Review 
In the XULRunner world this leads to problems (see bug 345541). It has been suggested that preventing liveconnect from exporting NSGetFactory may solve this problem.
Assignee: live-connect → benjamin
Status: NEW → ASSIGNED

        Attachment #236087 -
        Flags: review?

    
  

        Attachment #236087 -
        Flags: review? → review?(brendan)

    
    

    
  
Comment on attachment 236087 [details] [diff] [review]
Remove unused exports, rev. 1

Old stuff.  No LiveConnect owners on scene.  Perhaps Javier should take a look too?

/be

        Attachment #236087 -
        Flags: review?(jhpedemonte)

        Attachment #236087 -
        Flags: review?(brendan)

        Attachment #236087 -
        Flags: review+

        Attachment #236087 -
        Flags: review?(jhpedemonte) → review+

    
    

    
  
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
    

    
  
Now that this is in should the fix in bug 345541 be backed out?

    
    

    
  
I don't know, that was your bug ;-)

    
    

    
  
Does this violate our API-compat pledge for 181?

    
    

    
  
I don't think so. It's not a usable API in any case, just vestigial.

    
    

    
  
ok - if this is safe please nom for 1.8.1

    
  

        Attachment #236087 -
        Flags: approval1.8.1?

    
    

    
  
Comment on attachment 236087 [details] [diff] [review]
Remove unused exports, rev. 1

a=beltzner on behalf of 181drivers

        Attachment #236087 -
        Flags: approval1.8.1? → approval1.8.1+

    
    

    
  
Fixed on MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1

    
    

    
  
I can confirm that this fixes bug 345541 as well.

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.