Closed Bug 350688 Opened 15 years ago Closed 14 years ago

Dictionaries should form part of the locale pack in the installer

Categories

(SeaMonkey :: Installer, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(3 files, 1 obsolete file)

In the SeaMonkey installer we currently have the dictionaries and spellcheck components as one optional spellcheck installation selection. Robert commented on IRC that we should install the dictionaries with the locale xpi, and spellcheck as part of the browser xpi by default, as per FF & TB. The currently installed dictionary is approx 680kb in size so there isn't really much of a space saving by not installing it.
 
I think this is reasonable now that the spellcheck is used a lot more within the suite.
Attached patch Unix installer patch. (obsolete) — Splinter Review
Missed a file.
Attachment #236399 - Attachment is obsolete: true
Attachment #236401 - Flags: superreview?(neil)
Attachment #236401 - Flags: review?(ajschult)
Attachment #236401 - Flags: superreview?(neil) → superreview+
Attachment #236401 - Flags: review?(ajschult) → review+
I'm planning on checking this in on trunk today. I think it may start the nagios system complaining, so cc'ing some relevant people. The lines highlighted in the file from the link below will need removing if there are warnings given. As it isn't part of the main build system I didn't know if I should be providing a patch or not.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/tools/tinderbox-configs/monitoring/Seamonkey_trunk.txt&rev=1.2&mark=5,17
Attachment #236401 - Attachment description: Unix installer patch → Unix installer patch (checked in)
Comment on attachment 236404 [details] [diff] [review]
os2 installer patch (checked in)

I've not tested this as I don't have os2, but this is done in a similar way to the unix and windows patches on this bug.
Attachment #236404 - Flags: superreview?(neil)
Attachment #236404 - Flags: review?(mozilla)
Attachment #236404 - Flags: superreview?(neil) → superreview+
The Windows patch seems to work fine, the spell check program files ended up in browser.xpi, the dictionaries in langenus.xpi.
BTW: The packages-win part of the patch had some fuzz:
Hunk #1 succeeded at 38 (offset 1 line).
Hunk #2 succeeded at 189 (offset 14 lines).
Hunk #3 succeeded at 415 with fuzz 1 (offset 36 lines).
It applied cleanly anyway.
Comment on attachment 236403 [details] [diff] [review]
Windows installer patch (checked in)

Thanks to Frank for the testing, requesting reviews.
Attachment #236403 - Flags: superreview?(neil)
Attachment #236403 - Flags: review?(neil)
Attachment #236403 - Flags: superreview?(neil)
Attachment #236403 - Flags: superreview+
Attachment #236403 - Flags: review?(neil)
Attachment #236403 - Flags: review+
Attachment #236403 - Attachment description: Windows installer patch → Windows installer patch (checked in)
ping Michael: any chance of a review on the os2 installer patch sometime?
Comment on attachment 236404 [details] [diff] [review]
os2 installer patch (checked in)

I'm guessing Michael's away or busy, therefore switching review to Andrew.
Attachment #236404 - Flags: review?(mozilla) → review?(ajschult)
Attachment #236404 - Flags: review?(ajschult) → review+
Comment on attachment 236404 [details] [diff] [review]
os2 installer patch (checked in)

os2 patch checked in.
Attachment #236404 - Attachment description: os2 installer patch → os2 installer patch (checked in)
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.