350693 - "Character Encoding" in "View Source" window doesn't work

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect)

Description

[Timwi]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6

See STR:

Reproducible: Always

Steps to Reproduce:
1. Send yourself an e-mail with traditional Chinese characters, encoded as BIG5.
2. View the e-mail, and press Ctrl+U (opens View Source window)
3. Select View/Character Encoding/Western.

Actual Results:  
Nothing happens; still displays Chinese characters.

Expected Results:  
Character encoding should switch. Window should display a jungle of Latin-1 characters.

Comment 1

[Simon Montagu :smontagu]

Attachment: Patch

This is a port of Neil's patch to xpfe in bug 252317. It had r=doron, sr=bzbarsky over there, so I guess rs should be enough to apply it to toolkit.

Comment 2

[Scott MacGregor]

Comment on attachment 236818 [details] [diff] [review]
Patch

this needs a  toolkit module owner review so I'll ask Benjamin for that.

David's on vacation, i'll do the sr.

Comment 3

[[:Aleksej]]

OS -> All (also on Linux with Trunk 2007012403).

Comment 4

[Carsten Book [:Tomcat]]

-> OS change - its also confirmed on linux, see comment #3

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

For notes:

I tried patching this one to the latest trunk cvs, and it does apply cleanly, i.e. did not bit-rot.

Nominating wanted‑thunderbird3 to keep it on the radar.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 236818 [details] [diff] [review]
Patch

Can we get this in? Should be pretty safe, the corresponding xpfe fix has been there since 2004.

Comment 7

[Mike Schroepfer]

Comment on attachment 236818 [details] [diff] [review]
Patch

a+ schrep

Comment 8

[Magnus Melin [:mkmelin]]

Simon, I've checked this in for you.

Checking in toolkit/components/viewsource/content/viewSource.js;
/cvsroot/mozilla/toolkit/components/viewsource/content/viewSource.js,v  <--  viewSource.js
new revision: 1.24; previous revision: 1.23
done

->FIXED

Comment 9

[Joe Sabash [:JoeS1]]

Looks like this might have broken view source in
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008051003 Thunderbird/3.0a2pre ID:2008051003

See bug 433197

Comment 10

[Mike Cowperthwaite]

Bug 433197 has been fixed.  I can verify this fix works; if I look at the source of a message sent as ISO-2022-JP, selecting the encoding lets me see the intended script.  Nice!

V TB3pre2-0621, Win2K