351022 - confusing tab close confirmation dialog when restarting after update

Status: RESOLVED DUPLICATE of bug 385853

(Toolkit :: Application Update, defect)

Description

[Daniel Lipsitt]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1b1) Gecko/20060710 Firefox/2.0b1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1b1) Gecko/20060710 Firefox/2.0b1

The "confirm close" dialog that pops up when I am about to update is confusing. Which tabs is it talking about? What will happen to my other tabs? Will Session Restore work or not?

Reproducible: Always

Steps to Reproduce:
1. the 2.0b1 -> 2.0b2 update has been downloaded but not installed...
2. click Help->"Apply Downloaded Update Now"
3. click "Restart Firefox Now"

Actual Results:  
I get a dialog that says "You are about to close 4 open tabs. Are you sure you want to continue?" However, the window from which I invoked the update command has two tabs.

Expected Results:  
The dialog could say something like "Your windows and tabs will be restored when the restart is complete. You may need to log back in to some sites and you may lose unsubmitted form data" (assuming these things are true).

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

I don't see this with nightly updates, but can't find a bug that changed it.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Very probably a dupe of bug 341248

Comment 3

[(not reading, please use [e-mail] instead)]

> I get a dialog that says "You are about to close 4 open tabs. Are you sure you
> want to continue?" However, the window from which I invoked the update command
> has two tabs.

while this bug does seem like a dup, the "warn for 4, but only two tabs" concerns me.

Comment 4

[Daniel Lipsitt]

> while this bug does seem like a dup, the "warn for 4, but only two tabs"
> concerns me.

The oldest window I had open had four tabs. So the dialog I got was associated with the wrong window. In other words, I had many tabs open, spread across multiple windows, and it chose the oldest window to warn me about.

When I finally agreed to go ahead with the restart, I clicked okay to the tab close confirmation, but the browser did not exit. I discovered that it was because I had another multi-tab window open on a separate virtual desktop. That window also had a confirmation dialog open that I had to okay before the browser would restart.