351100 - [pinstripe] improve tabstrip background image (use the same one as winstripe)

Status: RESOLVED WONTFIX

(Firefox :: Tabbed Browser, defect)

Description

[(not reading, please use [e-mail] instead)]

should pinstripe use winstripe version of tabbrowser-tabs-bkgnd.png?

I like the winstripe version better than the pinstripe version (both from jay).

I'll attach two screen shots, and let some mac UI guru's chime in.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: as is (as of 9/1/06 checkins)

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: with the winstripe version of that .png file

Comment 3

[(not reading, please use [e-mail] instead)]

not really a blocker, but since this is new theme related for ff2, I'd like it to go by drivers.

additionally, the fix would be very low risk (just replacing an image.)

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 236472 [details]
with the winstripe version of that .png file

r+a=me for this theme fix.  bombes away.

Comment 5

[(not reading, please use [e-mail] instead)]

taking...

Comment 6

[(not reading, please use [e-mail] instead)]

fixed landed on the branch.

Comment 7

[Asa Dotzler [:asa]]

this change has some fall-out. The tab corners were apparently anti-aliased against the old background or something like that becuase now the unfocused tab (in both hover and not states) has defects on its corners. Also, there's now the illusion of a taller tab strip since the top of the background image matches the border pixel color so you get what appears to be a taller "deeper" (the convex appearance) tab strip that looks a bit odd.

Comment 8

[(not reading, please use [e-mail] instead)]

> this change has some fall-out. The tab corners were apparently anti-aliased
> against the old background or something like that becuase now the unfocused tab
>(in both hover and not states) has defects on its corners. Also, there's now
>the illusion of a taller tab strip since the top of the background image
>matches the border pixel color so you get what appears to be a taller "deeper"
>(the convex appearance) tab strip that looks a bit odd.

well put!  See bug #351435 which covers the corner defects (of at last the non-selected hover state, which is a transparency issue) and of the "illusion" issue.

Comment 9

[(not reading, please use [e-mail] instead)]

the optical illusion that the winstripe version of the background is distracting.

Compare:

old: https://bugzilla.mozilla.org/attachment.cgi?id=236471
new: https://bugzilla.mozilla.org/attachment.cgi?id=236472

mconnor/beltzner:  should I back it out?

(josh / mark, as mac gurus, what do you think? )

Comment 10

[Jay Goldman]

I prefer the old one myself - the gradient from Winstripe is too dark compared to the rest of the window on Pinstripe.

Comment 11

[(not reading, please use [e-mail] instead)]

sorry for leaving you out there, jay.

for me, the optical illusion is reason enough to revert to your original image.

I'll wait for beltzner / mconnor to weigh in.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Nice to have tried it, but I think Jay is right; let's go back to the old one.

Comment 13

[(not reading, please use [e-mail] instead)]

> Nice to have tried it, but I think Jay is right; let's go back to the old one.

I am going to revert it, r/a=beltzner.

Note, winstripe is now suffering from a similar optical illusion.

See https://bugzilla.mozilla.org/show_bug.cgi?id=350690#c94

Comment 14

[(not reading, please use [e-mail] instead)]

> Nice to have tried it, but I think Jay is right; let's go back to the old one.

I've backed myself out, assuming r/a=beltzner.

Comment 15

[(not reading, please use [e-mail] instead)]

wontfixing the original bug.

Comment 16

[(not reading, please use [e-mail] instead)]

> Note, winstripe is now suffering from a similar optical illusion.
>
> See https://bugzilla.mozilla.org/show_bug.cgi?id=350690#c94

the winstripe optical illusion has been addressed.