351267 - Scroll position re-used in autocomplete dropdown

Status: RESOLVED FIXED

(SeaMonkey :: Autocomplete, defect)

Description

[Andrew Schultz]

With linux seamonkey build 2006-09-03-08-trunk, if I select a choice from the autocomplete dropdown and then type something else to re-activate the dropdown, it scrolls to the position where it was the first time with nothing selected.

1. Load a bunch of .mozilla.org URLs
2. clear the location bar
3. type "m"
4. select an entry near the end
5. type "m"
==> dropdown scroll position near the end

The same happens if you type a different character at step 5, so it's not trying to be smart and re-select the entry you had before.  Firefox doesn't have this bug, but I don't see what it does differently.  Anyway, this isn't too hard to fix although there might be something more robust than what I have.

Comment 1

[Andrew Schultz]

Attachment: patch

This also scrolls to the top when typing if you scrolled down, but resetting the scroll position also seems desirable for that case (since the scroll position you get without this change is more or less random).

Comment 2

[[e-mail]]

Comment on attachment 236676 [details] [diff] [review]
patch

Hmm... rowCountChanged() is supposed to adjust the top row index...

Comment 3

[[e-mail]]

(In reply to comment #2)
>Hmm... rowCountChanged() is supposed to adjust the top row index...
Oh I see now, this is happening inside a batch update...

Comment 4

[[e-mail]]

Comment on attachment 236676 [details] [diff] [review]
patch

I guess this is as good a place as any to do this.

Comment 5

[Andrew Schultz]

fixed