Closed
Bug 351280
Opened 18 years ago
Closed 18 years ago
nsAccessible::GetTextFromRelationID is broken on 1.8 branch
Categories
(Core :: Disability Access APIs, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.8.1
People
(Reporter: asaf, Assigned: asaf)
References
Details
(Keywords: access, fixed1.8.1, regression)
Attachments
(1 file)
|
1.30 KB,
patch
|
aaronlev
:
review+
neil
:
superreview+
darin.moz
:
approval1.8.1+
|
Details | Diff | Splinter Review |
See the following code from nsAccessible.cpp
nsAutoString ids;
if (!content->GetAttr(kNameSpaceID_WAIProperties, aIDAttrib, ids)) {
return NS_ERROR_FAILURE;
}
Testing this with the labelledby attribute, we only get into this block if the attribute _is set_. I double checked and ids is actually set to the attribute value at this point.
|
Assignee | |
Updated•18 years ago
|
Flags: blocking1.8.1?
Target Milestone: --- → mozilla1.8.1
Version: Trunk → 1.8 Branch
|
|
Assignee | |
Updated•18 years ago
|
Blocks: 350615
Keywords: regression
|
||
Comment 1•18 years ago
|
||
In 1.8 GetAttr returns nsresult, not PRBool. http://lxr.mozilla.org/mozilla1.8/source/content/base/public/nsIContent.h#320 http://lxr.mozilla.org/seamonkey/source/content/base/public/nsIContent.h#277
|
|
Assignee | |
Comment 2•18 years ago
|
||
*oy*.
Assignee: general → aaronleventhal
Component: DOM → Disability Access APIs
QA Contact: ian → accessibility-apis
Summary: nsIContent::GetAttr returning false when the attribute is set (and vice-versa) in 1.8.1? → nsAccessible::GetTextFromRelationID is broken on 1.8 branch
|
|
Assignee | |
Comment 3•18 years ago
|
||
Assignee: aaronleventhal → bugs.mano
Status: NEW → ASSIGNED
Attachment #236690 -
Flags: superreview?(neil)
Attachment #236690 -
Flags: review?(aaronleventhal)
|
|
Assignee | |
Updated•18 years ago
|
Priority: -- → P1
|
||
Comment 4•18 years ago
|
||
Comment on attachment 236690 [details] [diff] [review] patch I noticed that the rest of the file seems to prefer NS_CONTENT_ATTR_HAS_VALUE for some reason.
Attachment #236690 -
Flags: superreview?(neil) → superreview+
|
||
Updated•18 years ago
|
Attachment #236690 -
Flags: review?(aaronleventhal) → review+
|
|
||
Updated•18 years ago
|
Attachment #236690 -
Flags: approval1.8.1?
|
|
Assignee | |
Updated•18 years ago
|
Attachment #236690 -
Flags: approval1.8.1?
|
|
Assignee | |
Updated•18 years ago
|
Attachment #236690 -
Flags: approval1.8.1?
|
||
Comment 5•18 years ago
|
||
Comment on attachment 236690 [details] [diff] [review] patch a=darin on behalf of drivers for the MOZILLA_1_8_BRANCH. please add the fixed1.8.1 keyword once this patch has landed.
Attachment #236690 -
Flags: approval1.8.1? → approval1.8.1+
|
|
Assignee | |
Comment 6•18 years ago
|
||
1.8 branch: mozilla/accessible/src/base/nsAccessible.cpp 1.165.2.12
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: Low risk
|
|
Assignee | |
Updated•18 years ago
|
Flags: blocking1.8.1?
You need to log in
before you can comment on or make changes to this bug.
Description
•