351321 - italic and bold font for high and low priority

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, enhancement)

Description

[Damian Szczepanik]

It will be nice if events with high priority are written formatted as bold and low as italic.

There is extra column for tasks but not for events. Small future but makes easy to  catch urgent events.

I found out similar bug 215936 but this is for still tasks.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Sounds reasonable to me, could probably be done quite easily using userChrome.css if not implemented in core:

#unifinder-search-results-tree > treechildren::-moz-tree-cell-text(highpriority) {
   font-weight: bold;
}

#unifinder-search-results-tree > treechildren::-moz-tree-cell-text(lowpriority) {
   font-style: italic;
   color: #CCCCCC !important;
}


I don't know why !important is needed for the color, but it is for me.

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Screenshot - v1

I unfortunately don't know a solution to make the color of the low prio events be system theme dependent, there is no system font color that makes sense.

I also don't know why I need to set that color important. Martin, maybe you have an idea?

Comment 4

[Stefan Sitter [:ssitter]]

Don't set the color without a background color. It will probably regress the issues we fixed in 1.0pre regarding list entries being not readable on certain color themes or focus situations. It's probably better to drop the color change at all.

Why not just show the priority column in the unifinder like in the task list?

Comment 5

[Martin Schröder [:mschroeder]]

Comment on attachment 397501 [details] [diff] [review]
Fix - v1

r+ with the color change left out (although this should be decided by ui-review). If you get ui-r+, make sure to define a background-color.

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 397502 [details]
Screenshot - v1

looks good, but I'd leave out the color change as it is a bit hard to read.

Likely you're looking for color: GrayText; anyway as it will work better for a11y themes

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

As discussed with clarkbw on IRC, using italic alone will make low prio events stick out more than normal events. I tried font-weight, but only bold and normal is implemented. Now we will use color: GrayText; background-color: -moz-field.

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/898078628dd5>

-> FIXED

Comment 8

[Damian Szczepanik]

I can't see differences, no matter which priority is set, colour and font weight is still the same.

I see additional icon for tasks but nothing else is changed

checking with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9pre) Gecko/20100223 Calendar/1.0b2pre

Comment 9

[Stefan Sitter [:ssitter]]

Are you sure you are looking at the unifinder and not the task list?

It works fine for me using Mozilla/5.0 (Windows; U; Windows NT 6.1; de; rv:1.9.1.9pre) Gecko/20100223 Calendar/1.0b2pre.

Comment 10

[Damian Szczepanik]

(In reply to comment #9)
> Are you sure you are looking at the unifinder and not the task list?

right, that's the problem, unifinder shows correctly

Comment 11

[Philipp Kewisch [:Fallen][📱📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".