351332 - Move Group validation into Bugzilla::Bug from post_bug.cgi

Status: RESOLVED FIXED

Description

[Max Kanat-Alexander]

post_bug.cgi does a lot of group validations, and these should all move into Bugzilla::Bug. Basically, this is just code that will tell us what groups the bug is in, given the product and certain input.

Comment 1

[Max Kanat-Alexander]

Created attachment 236738 [details] [diff] [review]
v1

Okay, here we go. Easy, easy. Doesn't depend on any previous bugs.

This cleaned up the code a lot.

Comment 2

[Max Kanat-Alexander]

Created attachment 237540 [details] [diff] [review]
v1.1

Fixed bitrot.

Comment 3

[Frédéric Buclin]

Comment on attachment 237540 [details] [diff] [review]
v1.1

>Index: post_bug.cgi

>-        if (!GroupIsActive($v)) {

Nit: this was the single place using GroupIsActive(). Please remove this routine from post_bug.cgi on checkin as we don't use it at all anymore. r=LpSolit

Comment 4

[Max Kanat-Alexander]

Okay, I did the checkin fix.

Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.175; previous revision: 1.174
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.150; previous revision: 1.149
done
Checking in template/en/default/global/code-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-error.html.tmpl,v  <--  code-error.html.tmpl
new revision: 1.84; previous revision: 1.83
done

Comment 5

[Frédéric Buclin]

*** Bug 323240 has been marked as a duplicate of this bug. ***