Closed
Bug 351332
Opened 19 years ago
Closed 19 years ago
Move Group validation into Bugzilla::Bug from post_bug.cgi
Categories
(Bugzilla :: Creating/Changing Bugs, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: mkanat, Assigned: mkanat)
References
Details
Attachments
(1 file, 1 obsolete file)
6.24 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
post_bug.cgi does a lot of group validations, and these should all move into Bugzilla::Bug. Basically, this is just code that will tell us what groups the bug is in, given the product and certain input.
Assignee | ||
Comment 1•19 years ago
|
||
Okay, here we go. Easy, easy. Doesn't depend on any previous bugs.
This cleaned up the code a lot.
Assignee: create-and-change → mkanat
Status: NEW → ASSIGNED
Attachment #236738 -
Flags: review?(bugzilla-mozilla)
Updated•19 years ago
|
Version: 2.99 → 2.23
Assignee | ||
Updated•19 years ago
|
Target Milestone: --- → Bugzilla 3.0
Assignee | ||
Updated•19 years ago
|
Attachment #236738 -
Flags: review?(bugzilla-mozilla) → review?(LpSolit)
Assignee | ||
Comment 2•19 years ago
|
||
Fixed bitrot.
Attachment #236738 -
Attachment is obsolete: true
Attachment #237540 -
Flags: review?(LpSolit)
Attachment #236738 -
Flags: review?(LpSolit)
![]() |
||
Comment 3•19 years ago
|
||
Comment on attachment 237540 [details] [diff] [review]
v1.1
>Index: post_bug.cgi
>- if (!GroupIsActive($v)) {
Nit: this was the single place using GroupIsActive(). Please remove this routine from post_bug.cgi on checkin as we don't use it at all anymore. r=LpSolit
Attachment #237540 -
Flags: review?(LpSolit) → review+
![]() |
||
Updated•19 years ago
|
Flags: approval?
Updated•19 years ago
|
Flags: approval? → approval+
Assignee | ||
Comment 4•19 years ago
|
||
Okay, I did the checkin fix.
Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v <-- post_bug.cgi
new revision: 1.175; previous revision: 1.174
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v <-- Bug.pm
new revision: 1.150; previous revision: 1.149
done
Checking in template/en/default/global/code-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-error.html.tmpl,v <-- code-error.html.tmpl
new revision: 1.84; previous revision: 1.83
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
![]() |
||
Comment 5•19 years ago
|
||
*** Bug 323240 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•