351345 - Move keyword insertion out of post_bug.cgi and into Bugzilla::Bug

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Max Kanat-Alexander]

This one's a little trickier, because there's more code for inserting keywords. But we can handle it!

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Here we go. Tested and works.

You'll also notice that I did a bit of refactoring in run_create_validators to make things simpler overall.

Comment 2

[Max Kanat-Alexander]

Attachment: v1.1

Fixed bitrot.

Comment 3

[Frédéric Buclin]

Comment on attachment 236839 [details] [diff] [review]
v1.1

The patch is slightly bitrotten. I will attach the unbitrotten one in a few seconds. Your patch is working fine. r=LpSolit

Comment 4

[Frédéric Buclin]

Attachment: patch, v1.2

Here is the one I tested.

Comment 5

[Max Kanat-Alexander]

Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.177; previous revision: 1.176
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.152; previous revision: 1.151
done

Comment 6

[Frédéric Buclin]

*** Bug 323241 has been marked as a duplicate of this bug. ***

Comment 7

[Lucas Malor (mail: c6kfnkn2uc AT snkmail DOT c0m)]

I must say I usually add some keyword for completeness. Doing it after bug report seems to be spam, IMO.

Can I open a bug to request to move back keyword insertion into enter_bug.cgi?

Comment 8

[Max Kanat-Alexander]

(In reply to comment #7)
> Can I open a bug to request to move back keyword insertion into enter_bug.cgi?

  Um, it's still on enter_bug. This bug has nothing to do with the UI.

Comment 9

[Lucas Malor (mail: c6kfnkn2uc AT snkmail DOT c0m)]

I don't see it. Fields displayed are Product, Component, Hardware, OS, Identifier, URL, Summary, Details, Reproducible, Steps, Result, Expected, Other info, Security, Severity.