Closed Bug 351373 Opened 17 years ago Closed 17 years ago

Can't use keywords with "Open URL in Camino" Service

Categories

(Camino Graveyard :: OS Integration, enhancement)

Product:
Camino Graveyard
Component:
OS Integration
Version:
1.8 Branch
Platform:
PowerPC
macOS
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Camino1.5

People

(Reporter: froodian, Assigned: stuart.morgan+bugzilla)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

patch
2.68 KB, patch
froodian
: review+
sfraser_bugs
: superreview+
Details | Diff | Splinter Review 
I don't see any reason we shouldn't allow any string to be opened as a URL via the service.  For advanced users, it would be amazing to have keywords suddenly be system-wide - in any app, I could highlight something like "bug 1234", invoke the service, and have it open the appropriate bug.
Also, if we did this, we wouldn't have to accept any string blindly.  We could still use |stringByTrimmingCharactersInSet| to trim off excess whitespace before and after the string.
Ooh, that's a neat idea. Me likey.

Can we stick this on the agenda for tomorrow? It'd be wicked cool to have it in 1.1 (doesn't seem like it's too complicated).
Attached patch patch — — Splinter Review 
Enables keyword processing in URLs opened via the URL service.
Assignee: nobody → stuart.morgan
Status: UNCONFIRMED → ASSIGNED
Attachment #240864 - Flags: review?
Comment on attachment 240864 [details] [diff] [review]
patch

r=me
Attachment #240864 - Flags: superreview?(sfraser_bugs)
Attachment #240864 - Flags: review?
Attachment #240864 - Flags: review+
Attachment #240864 - Flags: superreview?(sfraser_bugs) → superreview+
Checked in on trunk and 1.8branch.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.